Repository navigation
Conversation
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jpnurmi/ref/native-crashing #2174 +/- ##
===============================================================
- Coverage 75.39% 75.06% -0.33%
===============================================================
Files 103 103
Lines 28119 28314 +195
Branches 5158 5202 +44
===============================================================
+ Hits 21199 21255 +56
- Misses 5587 5700 +113
- Partials 1333 1359 +26 🚀 New features to boost your workflow:
|
mujacica
approved these changes
Oct 8, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bcf18cf. Configure here.
jpnurmi
force-pushed
the
jpnurmi/feat/native-crash-stack
branch
from
October 8, 2026 18:46
bcf18cf to
59a96d8
Compare
jpnurmi
added this pull request to stack #2181
October 8, 2026 18:47
Provide exception metadata, registers, and a basic crashing-thread stack for crash identification in native `on_crash`, matching `inproc`. Use the same payload for `before_send` when `on_crash` is unset. - Capture up to 128 fault-context IPs and unwind source in shared memory. Retain the faulting IP when available. - Linux: SDK `libunwind` with signal-safe logging. - macOS: SDK frame-pointer walker, guarded Mach reads, PAC stripping, `__DARWIN_OPAQUE_ARM_THREAD_STATE64` accessors, and `instruction_addr_adjustment=none`. - Android/Linux without `libunwind`: bounded frame-pointer capture via `process_vm_readv`; avoids `libunwindstack`'s C++ allocation. - Windows: MSVC x64 `RtlLookupFunctionEntry`/`RtlVirtualUnwind` walking without DbgHelp; SP progress permits recursive frames. Frame-pointer capture on x86/ARM64 and other x64 builds. - ARM32 frame-pointer fallbacks retain only the faulting IP. The daemon reuses partial captures and enriches existing frames. Preserve exception/register/frame edits and removals, and honor callback rejection.
jpnurmi
force-pushed
the
jpnurmi/feat/native-crash-stack
branch
from
October 9, 2026 07:49
59a96d8 to
fda25c6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse and extend the existing SDK unwinders already used by
inprocto provide exception metadata, registers, and a basic crashing-thread stack for crash identification in nativeon_crash, matchinginproc.libunwindwith signal-safe logging.__DARWIN_OPAQUE_ARM_THREAD_STATE64accessors, andinstruction_addr_adjustment=none.libunwind: bounded frame-pointer capture viaprocess_vm_readv; avoidslibunwindstack's C++ allocation.RtlLookupFunctionEntry/RtlVirtualUnwindwalking without DbgHelp; SP progress permits recursive frames. Frame-pointer capture on x86/ARM64 and other x64 builds.The daemon reuses partial captures and enriches existing frames. Preserve exception/register/frame edits and removals, and honor callback rejection.
Ref: #2102