Repository navigation
Conversation
5593400 to
a3ffce7
Compare
a3ffce7 to
a38d913
Compare
a38d913 to
41100bf
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jpnurmi/ref/scope-flush-func #2107 +/- ##
================================================================
+ Coverage 75.55% 75.57% +0.01%
================================================================
Files 103 103
Lines 28171 28292 +121
Branches 5159 5179 +20
================================================================
+ Hits 21286 21383 +97
- Misses 5530 5560 +30
+ Partials 1355 1349 -6 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0083711. Configure here.
0083711 to
3852ecb
Compare
3852ecb to
cef816a
Compare
aeed6d1 to
2c04bee
Compare
2c04bee to
6dbd749
Compare
b81d020 to
f97158f
Compare
|
@limbonaut @tustanivsky some potential candidates for write-locked batch updates that would fold several flushes into one:
|
limbonaut
left a comment
There was a problem hiding this comment.
Looks really neat! 🚢 🗺️
Q: Can users use these with the global scope? Probably need either sentry_begin_write or an actual accesor for the global scope.
Which would you prefer? With |
|
It can also be a more explicit name such as |
Hmmm, now that I think of it, we might have coincidentally eliminated the blocker problems with the recent RW-lock changes. Before, all global scope access was exclusively locked during Exposing the global scope is tempting because it would allow being more selective with the global vs. scope API duplication going forward... 🤔 |
I think you are right. Something like |
f97158f to
ecb41a7
Compare
f65ce04 to
b1503ad
Compare
b1503ad to
9646003
Compare
a0d9e0e to
72e1895
Compare
72e1895 to
7eeb226
Compare
7eeb226 to
441401f
Compare
Keep the scope write lock across a batch while allowing the owning thread to use existing scope accessors without relocking. Defer backend scope flushes until the outermost batch completes.
441401f to
bf866ff
Compare

Keep the scope read or write lock across a batch while allowing the owning thread to use existing scope accessors without relocking.
This tackles two use-cases: