Skip to content

feat(build): shared library version - #2103

Merged
jpnurmi merged 1 commit into
v1from
jpnurmi/build/so-version
Oct 14, 2026
Merged

jpnurmi merged 1 commit into
v1from
jpnurmi/build/so-version

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Set CMake VERSION and SOVERSION properties to indicate the major release and ABI-compatibility versions.

Caution

Breaking / Important behavior change

macOS/Linux: shared libraries now use ABI-versioned filenames, such as libsentry.1.dylib or libsentry.so.1 for 1.x. Windows, Android, and static libraries remain unchanged.

NOTE: Applications must package the real versioned library and its symlinks, including libsentry.1.dylib or libsentry.so.1, because they link to and load the ABI-versioned name.

Close: #1428

@jpnurmi jpnurmi mentioned this pull request Sep 17, 2026
3 of 7 tasks

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread tests/test_build.py
@jpnurmi
jpnurmi added this pull request to stack #2106 September 17, 2026 13:24
@jpnurmi
jpnurmi force-pushed the jpnurmi/build/so-version branch 2 times, most recently from 076dc30 to c0987c9 Compare September 17, 2026 14:13
Comment thread .craft.yml Outdated

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread .craft.yml Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/build/so-version branch 2 times, most recently from 3dfb508 to 5b4b6de Compare September 17, 2026 16:01
Comment thread CMakeLists.txt Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/build/so-version branch from 5b4b6de to 7ef38df Compare September 17, 2026 16:11
Comment thread CMakeLists.txt

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7ef38df. Configure here.

Comment thread tests/test_integration_crashpad.py
@jpnurmi
jpnurmi force-pushed the jpnurmi/build/so-version branch 2 times, most recently from 584534b to 54e9245 Compare September 17, 2026 16:31
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.53%. Comparing base (212b6a6) to head (c229fa5).
⚠️ Report is 2 commits behind head on v1.

Additional details and impacted files
@@            Coverage Diff             @@
##               v1    #2103      +/-   ##
==========================================
+ Coverage   75.37%   75.53%   +0.15%     
==========================================
  Files         103      103              
  Lines       28208    28208              
  Branches     5168     5168              
==========================================
+ Hits        21261    21306      +45     
+ Misses       5602     5548      -54     
- Partials     1345     1354       +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linear-code

linear-code Bot commented Sep 23, 2026

Copy link
Copy Markdown

NATIVE-138

@jpnurmi jpnurmi changed the title [1.0] feat(build): shared library version feat(build): shared library version Sep 23, 2026
@jpnurmi jpnurmi added the v1 Targets 1.0 (v1 branch) label Sep 23, 2026
@jpnurmi
jpnurmi removed this pull request from stack #2106 October 14, 2026 07:43
@jpnurmi
jpnurmi changed the base branch from master to v1 October 14, 2026 07:43
@jpnurmi
jpnurmi force-pushed the jpnurmi/build/so-version branch from 54e9245 to c229fa5 Compare October 14, 2026 07:45
@github-actions

Copy link
Copy Markdown
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c229fa5

@jpnurmi
jpnurmi added this pull request to stack #2197 October 14, 2026 08:17
@jpnurmi
jpnurmi merged commit a6ee584 into v1 Oct 14, 2026
66 of 69 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/build/so-version branch October 14, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 Targets 1.0 (v1 branch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Provide ABI version information to ELF, Mach-O and PE artifacts

2 participants