Conversation
…s add orchestrion `sentryCloudflareVitePlugin` and a framework plugin such as `sentryReactRouter` both add the orchestrion Vite plugin to one build. Both instances then transform each instrumented module, the second one declares the injected snippet again, and the build fails with a redeclaration error. The plugin is now named `sentry-orchestrion`, and an instance that finds an earlier one in the same build leaves the transform to it. `react-router-8-framework` no longer needs `buildTimeInstrumentation: false` in its Cloudflare config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentryCloudflareVitePluginand a framework's Sentry Vite plugin, such assentryReactRouter, both add the orchestrion Vite plugin. On Cloudflare, every instrumented module was then transformed twice, and the build failed because the injectedorchestrionModuleInjectedsnippet was declared twice. Apps had to setbuildTimeInstrumentation: falseon the framework plugin.The plugin is now named
sentry-orchestrion, like the Bun plugin. InconfigResolved, an instance that finds an earlier plugin with that name in the same build skips the transform and the externalized-modules warning. The name lookup also works when the two SDKs bring different copies of@sentry/server-utils. The diagnostics banner that both instances still add is idempotent.react-router-8-frameworkdrops the workaround from its Cloudflare config, so the Cloudflare e2e variant now builds with both plugins.Part of #24836
🤖 Generated with Claude Code