test(e2e): Cover isolation, trace propagation and logs on all react-router-8-framework runtimes - #25041
Draft
JPeer264 wants to merge 1 commit into
Draft
test(e2e): Cover isolation, trace propagation and logs on all react-router-8-framework runtimes#25041JPeer264 wants to merge 1 commit into
JPeer264 wants to merge 1 commit into
Conversation
…outer-8-framework runtimes Adds tests for per-request isolation, incoming trace continuation, trace propagation to an outgoing `fetch`, and logs to `react-router-8-framework`. They pass on Node, Bun, Deno and Cloudflare without a runtime branch. With all runtimes green, the Bun, Deno and Cloudflare variants move from `optionalVariants` to the required `variants`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the assertions that #24836 lists and
react-router-8-frameworkdid not have: per-request isolation, incoming trace continuation, trace propagation to an outgoingfetch, and logs. They pass on Node, Bun, Deno and Cloudflare without a runtime branch, so the audit's Bun findings for isolation, incoming trace and outgoingfetch, and its Denofetchfinding, no longer reproduce with@sentry/bunand@sentry/deno. With every runtime green, the Bun, Deno and Cloudflare variants move to the requiredvariants.The isolation test holds the first of two concurrent requests until the second one has set its tag, so both scopes are in use at the same time without a timer. The
fetchtest finds its spans through thesentry-traceheader that the target route received, because the server span of a resource route is not named after the route yet (GET /{*splat}on Node and Deno,GETon Bun and Cloudflare).Part of #24836
🤖 Generated with Claude Code