Skip to content

fix(feedback): Correct overlapping screenshot annotations and drag dimming - #25040

Draft
msonnb wants to merge 1 commit into
developfrom
ms/feedback-annotator
Draft

msonnb wants to merge 1 commit into
developfrom
ms/feedback-annotator

Conversation

@msonnb

@msonnb msonnb commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Fix screenshot annotations starting at the wrong position when a drag begins inside an existing box, and prevent the background from getting darker while dragging. Mouse-down now uses image-relative coordinates consistently, and highlight shadows no longer leak into the next canvas repaint.

Five Chromium regression cases fail before the fix and pass afterward, covering both tools, both drag directions, and background opacity. Format, development build, lint, and browser type checks pass. The full unit run passes 40 of 42 projects; Solid and SolidStart fail resolving @testing-library/jest-dom/dist/vitest.mjs in the local worktree.

Before/after from a local reproduction with generated sample content. Both captures show the same drag with the mouse held down; red markers indicate its start and cursor positions.

Before After
Before After

…mming

Co-Authored-By: OpenAI Codex <codex@openai.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant