test(node): port filesystem integration tests to span streaming - #25019
Merged
Merged
Conversation
nicohrubec
marked this pull request as ready for review
October 5, 2026 06:39
nicohrubec
requested review from
JPeer264,
andreiborza,
isaacs and
mydea
and removed request for
a team
October 5, 2026 06:39
JPeer264
approved these changes
Oct 5, 2026
|
|
||
| test('does not record file paths on successful operations when only `recordErrorMessagesAsSpanAttributes` is enabled', async () => { | ||
| const runner = createRunner() | ||
| .unordered() |
Member
There was a problem hiding this comment.
l: I think this could get removed as there is only one span. Same for the other additions of unordered in this file
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
force-pushed
the
feat/node-fs-default-streaming
branch
from
October 5, 2026 09:39
562874d to
a43afb6
Compare
nicohrubec
enabled auto-merge (squash)
October 5, 2026 09:41
nicohrubec
disabled auto-merge
October 5, 2026 09:41
nicohrubec
enabled auto-merge (squash)
October 5, 2026 09:42
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run filesystem instrumentation tests with the default span-streaming lifecycle. Preserve the existing path, error, and recording-option assertions while adapting them to streamed span fields. Each test asserts its request's span container directly.
Closes #24141 (JS-3611)