Repository navigation
fix(nextjs): Skip init inside a request of @sentry/cloudflare - #24996
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
JPeer264
force-pushed
the
jp/nextjs-skip-init-in-cloudflare-request
branch
from
October 3, 2026 16:14
20fa56b to
97c3369
Compare
JPeer264
added this pull request to stack #25035
October 5, 2026 08:43
JPeer264
force-pushed
the
jp/nextjs-skip-init-in-cloudflare-request
branch
from
October 5, 2026 09:13
97c3369 to
5fe8fa2
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
JPeer264
force-pushed
the
jp/nextjs-skip-init-in-cloudflare-request
branch
from
October 5, 2026 11:15
5fe8fa2 to
aab82c2
Compare
Base automatically changed from
jp/cloudflare-keep-otel-async-context-strategy
to
develop
October 5, 2026 14:47
JPeer264
force-pushed
the
jp/nextjs-skip-init-in-cloudflare-request
branch
from
October 5, 2026 14:47
aab82c2 to
07e8240
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6987310. Configure here.
JPeer264
force-pushed
the
jp/nextjs-skip-init-in-cloudflare-request
branch
from
October 6, 2026 06:42
6987310 to
94224ee
Compare
JPeer264
marked this pull request as ready for review
October 6, 2026 07:18
JPeer264
requested review from
chargome and
s1gr1d
and removed request for
a team
October 6, 2026 07:18
chargome
approved these changes
Oct 6, 2026
| | Nuxt server | Keeps the first client and returns it. Logs that a `--import` preload is no longer needed. | | ||
| | Cloudflare (default) | Keeps the first client of the isolate and returns it, unless that client is closed or closing. `cacheClient: false` makes a new client on each call, with no warning. | | ||
| | Next.js edge | Warns, then replaces the client. Returns `void`. | | ||
| | Next.js server and edge in a request of `withSentry` (Cloudflare) | Creates no client, because the client of `withSentry` handles the request. Returns `undefined`. | |
Member
There was a problem hiding this comment.
Why do we have this file in here? 😅
Member
Author
There was a problem hiding this comment.
This got added via #24962 and acts as a list of defined behaviors for our init() function. This will be then aligned in v12.
| * context strategy while the request runs (#24603). | ||
| */ | ||
| export function isAsyncContextOwnedByCloudflare(): boolean { | ||
| const strategy = getAsyncContextStrategy(getMainCarrier()); |
Member
There was a problem hiding this comment.
Just pointing out that this detection might be brittle bc @sentry/nextjs and @sentry/cloudlfare need to be on the exact same version for this to work
Member
Author
There was a problem hiding this comment.
Yeah it does. But I guess this will be solved when we add this as a optional peer dependency and is documented for the, soon to be added, @sentry/nextjs/cloudflare entrypoint
Edit: Ok maybe a direct dependency might be better. But that is for another PR
Next.js calls `register()` inside the first request. When the Worker is wrapped with `withSentry` from `@sentry/cloudflare`, the server and edge `init` then installed the OpenTelemetry async context strategy on the storage of that request, and every later request failed with `context.getValue is not a function`. On Cloudflare Workers, `init` now creates no client while a request of `withSentry` from `@sentry/cloudflare` runs, because that client already handles the request. Both still set the turbopack tag. The server `init` adds its event processors to the global scope there, because it has no client of its own and runs once per isolate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/nextjs-skip-init-in-cloudflare-request
branch
from
October 6, 2026 12:57
2bd0505 to
a205928
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next.js calls
register()inside the first request. When the Worker is wrapped withwithSentryfrom@sentry/cloudflare, the server and edgeinitinstalled the OpenTelemetry async context strategy on the storage of that running request, and every later request failed withcontext.getValue is not a function(#24603).On Workers,
initnow creates no client while a request ofwithSentryruns, because that client already handles the request. The SDK detects this from the installed strategy (AsyncLocalStorage, a store is set,Cloudflare-Workersuser agent) instead of a new option, so existing setups need no change. The serverinitstill adds its global event processors and theturbopacktag, which also apply to the events of the Cloudflare client.🤖 Generated with Claude Code