Repository navigation
Conversation
msonnb
added this pull request to stack #24891
September 30, 2026 12:22
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/browser-tests-browser-tracing
branch
from
October 5, 2026 07:41
8d885e5 to
9849fe3
Compare
msonnb
force-pushed
the
ms/browser-tests-browser-tracing
branch
from
October 5, 2026 09:10
9849fe3 to
e483312
Compare
msonnb
force-pushed
the
ms/browser-tests-browser-tracing
branch
2 times, most recently
from
October 7, 2026 11:24
c0cc99e to
fa408e7
Compare
msonnb
force-pushed
the
ms/browser-tests-browser-tracing
branch
from
October 7, 2026 11:27
fa408e7 to
7436507
Compare
msonnb
marked this pull request as ready for review
October 7, 2026 12:32
msonnb
requested review from
Lms24 and
logaretm
and removed request for
a team
October 7, 2026 12:32
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
msonnb
force-pushed
the
ms/browser-tests-browser-tracing
branch
from
October 7, 2026 12:50
7436507 to
b0cd816
Compare
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
msonnb
force-pushed
the
ms/browser-tests-browser-tracing
branch
from
October 7, 2026 13:12
85274b7 to
5782a9a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
There are 5 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5782a9a. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
14
to
18
|
|
||
| const pageloadTransaction = await getFirstSentryEnvelopeRequest<Event>(page); | ||
|
|
||
| expect(pageloadTransaction.contexts?.trace?.op).toBe('pageload'); | ||
| expect(pageloadTransaction.contexts?.trace?.status).toBe('cancelled'); | ||
| expect(pageloadTransaction.contexts?.trace?.data?.['sentry.cancellation_reason']).toBe('document.hidden'); | ||
| expect(getSpanOp(pageloadSpan)).toBe('pageload'); | ||
| expect(pageloadSpan.status).toBe('ok'); | ||
| expect(pageloadSpan.attributes['sentry.cancellation_reason']?.value).toBe('document.hidden'); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: The backgroundtab-pageload streaming test incorrectly asserts the pageload span status is 'ok'. It should expect 'cancelled' when the tab is backgrounded.
Severity: LOW
Suggested Fix
In the backgroundtab-pageload test, change the assertion from expect(pageloadSpan.status).toBe('ok') to expect(pageloadSpan.status).toBe('cancelled'). This will align the test with the actual behavior of the registerBackgroundTabDetection function and the corresponding static test.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/backgroundtab-pageload/test.ts#L14-L18
Potential issue: The streaming `backgroundtab-pageload` test incorrectly expects a
pageload span to have a status of `'ok'` after the page is moved to the background. The
`registerBackgroundTabDetection` function is designed to change the span's status from
`'ok'` to `'cancelled'` in this scenario before the span is ended and streamed. As a
result, the test assertion `expect(pageloadSpan.status).toBe('ok')` will fail because
the actual status will be `'cancelled'`. This is confirmed by an equivalent static test
which correctly asserts the status is `'cancelled'`.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
Author
There was a problem hiding this comment.
streamed spans map cancelled to ok
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
logaretm
approved these changes
Oct 7, 2026
Lms24
approved these changes
Oct 8, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
just some optional improvement suggestions and a bug which we should address separately
| }); | ||
|
|
||
| expect(traceContextData![SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME]).toBeUndefined(); | ||
| expect(attributes[SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME]).toEqual({ type: 'string', value: 'new name' }); |
Member
There was a problem hiding this comment.
m: This is a bug. this attribute shouldn't be sent along. I'm fine with merging this PR first and fixing it in a follow-up, so not a blocker for this PR!
on that note, we likely need to remove the attribute in another code path than we already do for transactions, so I'd argue we should keep this test around in both variants, static and streamed.
| const testSpan = eventData.spans?.find(span => span.description === 'pageload-child-span'); | ||
| expect(getSpanOp(pageloadSpan)).toBe('pageload'); | ||
| expect(pageloadSpan.attributes['sentry.idle_span_discarded_spans']).toBeUndefined(); | ||
| expect(spans.length).toBeGreaterThanOrEqual(1); |
Member
There was a problem hiding this comment.
l: should this be 2? (child and pageload)
Suggested change
| expect(spans.length).toBeGreaterThanOrEqual(1); | |
| expect(spans.length).toBeGreaterThanOrEqual(2); |
| discarded_events: [ | ||
| { | ||
| category: 'transaction', | ||
| category: 'span', |
Member
There was a problem hiding this comment.
l: this could be flaky since the navigation span here could include child spans. probably fine to assert on quantity equalOrGreater than 1
| discarded_events: [ | ||
| { | ||
| category: 'transaction', | ||
| category: 'span', |
| await page.waitForTimeout(1000); | ||
| expect(txnsReceived).toEqual(0); | ||
| }); | ||
| expect(spansReceived).toHaveLength(0); |
Member
There was a problem hiding this comment.
l: this check now got a little weaker since we don't send the segments immediately when they finish but we wait for 500ms before flushing them. I think what we could do here is trigger a Sentry.flush() and then assert expect(spansReceived).toHaveLength(0); again.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise browserTracingIntegration with default span streaming, including low-cardinality names and children sent across envelopes. Retain the existing transaction counterparts as explicitly pinned
*-staticsuites to preserve compatibility coverage for navigation, pageloads, linked traces, timing, and sampling.Stacked on #24881 for the shared span collector and dynamic sampling context helpers.
Fixes #24142