Conversation
Contributor
size-limit report 📦
|
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
logaretm
force-pushed
the
awad/route-provider-remix
branch
from
September 24, 2026 18:04
3c9576d to
e270daf
Compare
logaretm
force-pushed
the
awad/route-provider-remix
branch
2 times, most recently
from
September 24, 2026 18:30
427cf63 to
f9b36b5
Compare
logaretm
force-pushed
the
awad/route-provider-remix
branch
from
September 24, 2026 18:50
f9b36b5 to
b27bc60
Compare
logaretm
force-pushed
the
awad/route-provider-remix
branch
from
September 24, 2026 19:11
b27bc60 to
f28f802
Compare
`maybeParameterizeRemixRoute` is already a pure matcher over the route manifest the Vite plugin injects at build time, it was just only reachable from the pageload and navigation instrumentation. Registered from `init()` rather than a tracing integration, because the manifest is on the global object before `Sentry.init` runs. Route parameterization no longer depends on tracing being enabled.
logaretm
force-pushed
the
awad/route-provider-remix
branch
from
September 24, 2026 19:59
f28f802 to
a9e340c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider for Remix from the route manifest the Vite plugin already injects at build time.
maybeParameterizeRemixRoutewas already a pure matcher over that manifest, it was just only reachable from the pageload and navigation instrumentation. Registered frominit()rather than a tracing integration, so route parameterization no longer depends on tracing being enabled.Same shape as #23552, and simpler: Remix has one manifest and no
basePathasymmetry.Part of #23556