ref(node): Remove OTel RPC metadata from http server spans - #23028
Merged
Conversation
The http server spans integration created OTel `RPCMetadata` and published it into the OTel context so a downstream instrumentation could set `.route`, which was then read back to set `http.route`. Nothing in the SDK ever writes that field (no `getRPCMetadata` caller), so the path was dead — route naming is done directly via `setHttpServerSpanRouteAttribute`. Removes the RPC metadata bits and the last `@opentelemetry/core` import from `@sentry/node` src. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
nicohrubec
marked this pull request as ready for review
August 4, 2026 19:20
nicohrubec
requested review from
andreiborza,
msonnb and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
August 4, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the OpenTelemetry RPC metadata bits from
httpServerSpansIntegrationin preparation for dropping the@opentelemetry/coredependency. The path was dead code since nothing in the SDK ever set the route field it read, and route naming already happens viasetHttpServerSpanRouteAttribute.Fixes #22280