Skip to content

fix(cloudflare): Get original waituntil in workflows - #23017

Merged
JPeer264 merged 1 commit into
developfrom
jp/reuse-waituntil-in-workflows
Aug 5, 2026
Merged

fix(cloudflare): Get original waituntil in workflows#23017
JPeer264 merged 1 commit into
developfrom
jp/reuse-waituntil-in-workflows

Conversation

@JPeer264

@JPeer264 JPeer264 commented Aug 4, 2026

Copy link
Copy Markdown
Member

closes #23005
closes #23005

We didn't use getOriginalWaitUntil for workflows, which could lead to deadlocks. We already added this for everything else, but workflows.

Since waitUntil is never undefined I also remoevd the | undefined return type in getOriginalWaitUntil - this doesn't have any user facing API so it is safe to remove.

@JPeer264 JPeer264 self-assigned this Aug 4, 2026
@JPeer264
JPeer264 requested a review from a team as a code owner August 4, 2026 13:11
@JPeer264
JPeer264 requested review from isaacs and mydea and removed request for a team August 4, 2026 13:11
@linear-code

linear-code Bot commented Aug 4, 2026

Copy link
Copy Markdown

JS-3270

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.83 kB - -
@sentry/browser - with treeshaking flags 28.03 kB - -
@sentry/browser (incl. Tracing) 47.25 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.27 kB - -
@sentry/browser (incl. Tracing, Profiling) 52 kB - -
@sentry/browser (incl. Tracing, Replay) 86.59 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.01 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.28 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 103.95 kB - -
@sentry/browser (incl. Feedback) 47.13 kB - -
@sentry/browser (incl. sendFeedback) 34.67 kB - -
@sentry/browser (incl. FeedbackAsync) 39.78 kB - -
@sentry/browser (incl. Metrics) 30.91 kB - -
@sentry/browser (incl. Logs) 31.14 kB - -
@sentry/browser (incl. Metrics & Logs) 31.81 kB - -
@sentry/react 31.63 kB - -
@sentry/react (incl. Tracing) 49.51 kB - -
@sentry/vue 34.92 kB - -
@sentry/vue (incl. Tracing) 49.24 kB - -
@sentry/svelte 29.86 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 47.54 kB - -
CDN Bundle (incl. Logs, Metrics) 33.41 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 48.95 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.75 kB - -
CDN Bundle (incl. Tracing, Replay) 85.18 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.5 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.01 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.31 kB - -
CDN Bundle - uncompressed 94.62 kB - -
CDN Bundle (incl. Tracing) - uncompressed 142.12 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.24 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 146.1 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 223.94 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 261.38 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 265.34 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 275.08 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 279.04 kB - -
@sentry/nextjs (client) 52.08 kB - -
@sentry/sveltekit (client) 47.71 kB - -
@sentry/core/server 65.59 kB - -
@sentry/core/browser 51.88 kB - -
@sentry/node 120.07 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 83.69 kB - -
@sentry/aws-serverless 92.19 kB - -
@sentry/cloudflare (withSentry) - minified 218.64 kB -0.01% -7 B 🔽
@sentry/cloudflare (withSentry) 538.86 kB +0.01% +11 B 🔺

View base workflow run

@JPeer264
JPeer264 force-pushed the jp/reuse-waituntil-in-workflows branch from 57c78d5 to cbd46d8 Compare August 5, 2026 08:54
@JPeer264
JPeer264 requested review from andreiborza and nicohrubec and removed request for isaacs and mydea August 5, 2026 08:54
@JPeer264
JPeer264 force-pushed the jp/reuse-waituntil-in-workflows branch from cbd46d8 to 564c7f3 Compare August 5, 2026 08:56
@JPeer264
JPeer264 enabled auto-merge (squash) August 5, 2026 09:12
@JPeer264
JPeer264 merged commit 31e4c50 into develop Aug 5, 2026
146 of 148 checks passed
@JPeer264
JPeer264 deleted the jp/reuse-waituntil-in-workflows branch August 5, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloudflare Workflow teardown can deadlock on instrumented waitUntil

2 participants