feat(remix)!: Do not double gate action form data capture - #23014
Open
chargome wants to merge 1 commit into
Open
feat(remix)!: Do not double gate action form data capture#23014chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7ff5998. Configure here.
Contributor
size-limit report 📦
|
`captureActionFormDataKeys` previously only took effect when `dataCollection.httpBodies` also included `'incomingRequest'`. It now opts in on its own, and takes precedence over `dataCollection`. Setting only `httpBodies` captures all fields. Values with a sensitive-looking field name (`password`, `token`, …) are replaced with `[Filtered]`, including explicitly allowlisted ones. Fixes #21295 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-2666-v11-do-not-double-gate-actionformdataattributes
branch
from
August 4, 2026 13:37
7ff5998 to
a5efc13
Compare
chargome
marked this pull request as ready for review
August 4, 2026 13:53
chargome
requested review from
andreiborza,
nicohrubec and
s1gr1d
and removed request for
a team and
s1gr1d
August 4, 2026 13:53
nicohrubec
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
captureActionFormDataKeyspreviously only took effect whendataCollection.httpBodiesalso included'incomingRequest'(double opt-in) . It now opts in on its own, and takes precedence overdataCollection. Setting onlyhttpBodiescaptures all fields, which is the new default in v11.Values with a sensitive-looking field name (
password,token, …) are replaced with[Filtered], including explicitly allowlisted ones.closes #21295