feat!: Use `handler` span op for terminal request handlers by msonnb · Pull Request #22871 · getsentry/sentry-javascript

msonnb · 2026-07-30T12:55:25Z

Collapses the terminal request-handler span ops across the server frameworks to the cross-framework handler op, so every "this is where the user's route handler runs" span shares one op regardless of framework.

Hono’s app.request() is an internal HTTP dispatch (one sub-app calling another in-process), so it is semantically an inbound server request and is now traced as http.server

Part of #22446

linear-code · 2026-07-30T12:55:28Z

JS-3105

github-actions · 2026-07-30T13:03:16Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	30.12 kB	-	-
@sentry/browser - with treeshaking flags	28.32 kB	-	-
@sentry/browser (incl. Tracing)	47.53 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	47.54 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	52.29 kB	-	-
@sentry/browser (incl. Tracing, Replay)	86.91 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	76.33 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	91.6 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	104.25 kB	-	-
@sentry/browser (incl. Feedback)	47.45 kB	-	-
@sentry/browser (incl. sendFeedback)	34.96 kB	-	-
@sentry/browser (incl. FeedbackAsync)	40.1 kB	-	-
@sentry/browser (incl. Metrics)	31.2 kB	-	-
@sentry/browser (incl. Logs)	31.41 kB	-	-
@sentry/browser (incl. Metrics & Logs)	32.11 kB	-	-
@sentry/react	31.93 kB	-	-
@sentry/react (incl. Tracing)	49.79 kB	-	-
@sentry/vue	35.2 kB	-	-
@sentry/vue (incl. Tracing)	49.51 kB	-	-
@sentry/svelte	30.14 kB	-	-
CDN Bundle	32.13 kB	-	-
CDN Bundle (incl. Tracing)	47.81 kB	-	-
CDN Bundle (incl. Logs, Metrics)	33.67 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	49.19 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	73.02 kB	-	-
CDN Bundle (incl. Tracing, Replay)	85.45 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	86.77 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	91.27 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	92.59 kB	-	-
CDN Bundle - uncompressed	95.27 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	142.78 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	99.9 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	146.75 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	224.6 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	262.03 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	266 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	275.74 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	279.69 kB	-	-
@sentry/nextjs (client)	52.36 kB	-	-
@sentry/sveltekit (client)	47.99 kB	-	-
@sentry/core/server	65.54 kB	+0.02%	+7 B 🔺
@sentry/core/browser	51.82 kB	-	-
@sentry/node	120.46 kB	+0.02%	+20 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)	0 B	added	added
@sentry/node - without tracing	84.09 kB	+0.01%	+1 B 🔺
@sentry/aws-serverless	92.59 kB	+0.01%	+1 B 🔺
@sentry/cloudflare (withSentry) - minified	217.81 kB	-	-
@sentry/cloudflare (withSentry)	537.06 kB	-	-

View base workflow run

nicohrubec

looks like the PR needs to be rebased because it looks like the diff still includes the changes from #22852

isaacs

Some minor notes/questions, nothing worth gating, imo. Looks good!

At some point when these are all finished, we're going to likely want to add a note in MIGRATION.md to the effect that ignoreSpans: [{ op: 'express.router.middleware' }] or whatever will no longer work, because the op field is getting blunter.

isaacs · 2026-07-31T23:12:04Z


  const attributes: Record<string, string> = {
    [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: ORIGIN,
+    [SENTRY_OP]: REQUEST_HANDLER_OP,


If I'm reading this right, this puts a op: 'function' span as the parent of another op: 'function' span (on line 356), which seems a bit odd? Do we need an op here?

it's indeed a bit odd, will take a look in a follow-up 👍

isaacs · 2026-07-31T23:25:20Z

 /**
 * Patches `app.request()` on a Hono instance so that each internal dispatch
- * is traced as a `hono.request` span — child of whatever span is active at
+ * is traced as an `http.server` span — child of whatever span is active at


I had remembered seeing cases where http.server was assumed to be on root spans, and went looking for cases where it might be used as an indicator of root-ness. But they do not. Every one of them already holds the root before testing the op. So, I think this is safe.

isaacs · 2026-07-31T23:27:11Z


 function startMetadataSpan(metadata: SpanMetadata, original: () => unknown): unknown {
+  const hapiType = metadata.attributes[AttributeNames.HAPI_TYPE];
+  const op = hapiType === HapiLayerType.PLUGIN ? WEB_SERVER_FUNCTION_SPAN_OP : `${hapiType}.hapi`;


So, we still have op fields with .hapi? I thought that we were trying to make them all known conventional types? (If this is coming in a subsequent PR, ignore, it's fine to do these piecemeal, of course.)

yes this (and koa, express) will be updated to router which needs to land in conventions first

isaacs · 2026-07-31T23:27:36Z

Same comment here as the .hapi op above

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit d78a45b. Configure here.}

msonnb · 2026-08-04T09:12:03Z

At some point when these are all finished, we're going to likely want to add a note in MIGRATION.md to the effect that ignoreSpans: [{ op: 'express.router.middleware' }] or whatever will no longer work, because the op field is getting blunter.

yup i was planning on doing the MIGRATION note all at once at the end 👍

msonnb · 2026-08-05T16:04:32Z

Discussed with @Lms24 that we'll add a new handler op to conventions (release pending) that we use here instead. This avoids collapsing too much into function since request handlers are a pretty common thing across frameworks and SDKs.

Migrate the terminal request-handler span ops across the server integrations to the cross-framework `function` op, and trace Hono's internal `app.request()` dispatch as an `http.server` span: - express: `request_handler.express` -> `function` - fastify: `request_handler.fastify` -> `function` - elysia: `request_handler.elysia` -> `function` - nestjs: `handler.nestjs` -> `function` - hono: `hono.request` -> `http.server` Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

A plugin-registered hapi route runs the user's request handler, so it is a terminal handler like the express/fastify/hono routes in this migration. Map `plugin.hapi` to the cross-framework `function` op; `router.hapi` and `server.ext.hapi` (framework routing/extension lifecycle) keep their ops. Op is set via the `sentry.op` attribute only; `hapi.type` is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

## pnpm-workspace.yaml (default) ## Dependency Updates | Package | From | To | Type | | --- | --- | --- | --- | | `@sentry/cloudflare` | 10.75.0 | 11.0.0 | major | | `@sentry/react` | 10.75.0 | 11.0.0 | major | ## Release Notes <details> <summary>@sentry/cloudflare (10.75.0 → 11.0.0) — 4 releases</summary> <details> <summary>11.0.0</summary> Version `11.0.0` marks a major release of the Sentry JavaScript SDKs containing breaking changes. The goal of this release is to be better compatible with OpenTelemetry, make our integrations work across Node.js, Cloudflare, Bun and Deno through run-time and build-time instrumentation, and make span streaming and more permissive data collection the default. ### How To Upgrade Please carefully read through the migration guide in the Sentry docs on how to upgrade from version 10 to version 11. Make sure to select your specific platform/framework in the top left corner: https://docs.sentry.io/platforms/javascript/migration/v10-to-v11/ A comprehensive migration guide outlining all changes can be found within the Sentry JavaScript SDK Repository: https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md ### Breaking Changes #### All SDKs - feat: Remove support for initialising via `--require` ([#22513](getsentry/sentry-javascript#22513)) - feat!: Rename deprecated `http.*` span attributes ([#23574](getsentry/sentry-javascript#23574)) - feat!: Rename deprecated `net.` span attributes ([#23301](getsentry/sentry-javascript#23301)) - feat!: Replace `skipOpenTelemetrySetup` with `enableOpenTelemetrySetup` ([#23199](getsentry/sentry-javascript#23199)) - feat!: Replace the deprecated `http.target` span attribute ([#23575](getsentry/sentry-javascript#23575)) - feat!: Require Node `>=20.19.0` as minimum supported version ([#22558](getsentry/sentry-javascript#22558)) - feat!: Use `handler` span op for terminal request handlers ([#22871](getsentry/sentry-javascript#22871)) - feat!: Use `middleware` span op for web-server middleware ([#22852](getsentry/sentry-javascript#22852)) - feat(frameworks)!: Use `function` op for framework functions ([#23047](https://github.com/getse …[full notes](https://github.com/getsentry/sentry-javascript/releases/tag/11.0.0) </details> <details> <summary>10.75.3</summary> - fix(v10/tanstackstart-react): Reject non-POST requests to the managed tunnel route ([#24617](getsentry/sentry-javascript#24617)) <details> <summary>Internal Changes</summary> - chore(v10/bundler-plugins): move traces sample rate from 1.0 to 0.3 ([#24646](getsentry/sentry-javascript#24646)) - chore(v10/publish): Tag all packages as v10 ([#24619](getsentry/sentry-javascript#24619)) </details> ## Bundle size 📦 | Path | Size | | -------------------------------------------------------------------------- | ----------------- | | @sentry/browser | 27.56 KB | | @sentry/browser - with treeshaking flags | 26.04 KB | | @sentry/browser (incl. Tracing) | 46.02 KB | | @sentry/browser (incl. Tracing + Span Streaming) | 47.77 KB | | @sentry/browser (incl. Tracing, Profiling) | 50.67 KB | | @sentry/browser (incl. Tracing, Replay) | 84.38 KB | | @sentry/browser (incl. Tracing, Replay) - with treeshaking flags | 74.28 KB | | @sentry/browser (incl. Tracing, Replay with Canvas) | 89 KB | | @sentry/browser (incl. Tracing, Replay, Feedback) | 101.33 KB | | @sentry/browser (incl. Feedback) | 44.33 KB | | @sentry/browser (incl. sendFeedback) | 32.25 KB | | @sentry/browser (incl. FeedbackAsync) | 37.27 KB | | @sentry/browser (incl. Metrics) | 28.63 KB | | @sentry/browser (incl. Logs) | 28.84 KB | | @sentry/bro …[full notes](https://github.com/getsentry/sentry-javascript/releases/tag/10.75.3) </details> …and 2 more release(s) not shown </details> <details> <summary>@sentry/react (10.75.0 → 11.0.0) — 4 releases</summary> <details> <summary>11.0.0</summary> Version `11.0.0` marks a major release of the Sentry JavaScript SDKs containing breaking changes. The goal of this release is to be better compatible with OpenTelemetry, make our integrations work across Node.js, Cloudflare, Bun and Deno through run-time and build-time instrumentation, and make span streaming and more permissive data collection the default. ### How To Upgrade Please carefully read through the migration guide in the Sentry docs on how to upgrade from version 10 to version 11. Make sure to select your specific platform/framework in the top left corner: https://docs.sentry.io/platforms/javascript/migration/v10-to-v11/ A comprehensive migration guide outlining all changes can be found within the Sentry JavaScript SDK Repository: https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md ### Breaking Changes #### All SDKs - feat: Remove support for initialising via `--require` ([#22513](getsentry/sentry-javascript#22513)) - feat!: Rename deprecated `http.*` span attributes ([#23574](getsentry/sentry-javascript#23574)) - feat!: Rename deprecated `net.` span attributes ([#23301](getsentry/sentry-javascript#23301)) - feat!: Replace `skipOpenTelemetrySetup` with `enableOpenTelemetrySetup` ([#23199](getsentry/sentry-javascript#23199)) - feat!: Replace the deprecated `http.target` span attribute ([#23575](getsentry/sentry-javascript#23575)) - feat!: Require Node `>=20.19.0` as minimum supported version ([#22558](getsentry/sentry-javascript#22558)) - feat!: Use `handler` span op for terminal request handlers ([#22871](getsentry/sentry-javascript#22871)) - feat!: Use `middleware` span op for web-server middleware ([#22852](getsentry/sentry-javascript#22852)) - feat(frameworks)!: Use `function` op for framework functions ([#23047](https://github.com/getse …[full notes](https://github.com/getsentry/sentry-javascript/releases/tag/11.0.0) </details> <details> <summary>10.75.3</summary> - fix(v10/tanstackstart-react): Reject non-POST requests to the managed tunnel route ([#24617](getsentry/sentry-javascript#24617)) <details> <summary>Internal Changes</summary> - chore(v10/bundler-plugins): move traces sample rate from 1.0 to 0.3 ([#24646](getsentry/sentry-javascript#24646)) - chore(v10/publish): Tag all packages as v10 ([#24619](getsentry/sentry-javascript#24619)) </details> ## Bundle size 📦 | Path | Size | | -------------------------------------------------------------------------- | ----------------- | | @sentry/browser | 27.56 KB | | @sentry/browser - with treeshaking flags | 26.04 KB | | @sentry/browser (incl. Tracing) | 46.02 KB | | @sentry/browser (incl. Tracing + Span Streaming) | 47.77 KB | | @sentry/browser (incl. Tracing, Profiling) | 50.67 KB | | @sentry/browser (incl. Tracing, Replay) | 84.38 KB | | @sentry/browser (incl. Tracing, Replay) - with treeshaking flags | 74.28 KB | | @sentry/browser (incl. Tracing, Replay with Canvas) | 89 KB | | @sentry/browser (incl. Tracing, Replay, Feedback) | 101.33 KB | | @sentry/browser (incl. Feedback) | 44.33 KB | | @sentry/browser (incl. sendFeedback) | 32.25 KB | | @sentry/browser (incl. FeedbackAsync) | 37.27 KB | | @sentry/browser (incl. Metrics) | 28.63 KB | | @sentry/browser (incl. Logs) | 28.84 KB | | @sentry/bro …[full notes](https://github.com/getsentry/sentry-javascript/releases/tag/10.75.3) </details> …and 2 more release(s) not shown </details> --- *This PR was auto-generated by [catalog-update-action](https://github.com/brandhaug/catalog-update-action).* Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

msonnb changed the title ~~feat(node)!: Use function span op for terminal request handlers~~ feat!: Use function span op for terminal request handlers Jul 30, 2026

msonnb marked this pull request as ready for review July 31, 2026 07:35

msonnb requested review from a team as code owners July 31, 2026 07:35

msonnb requested review from isaacs, mydea, nicohrubec and s1gr1d and removed request for a team July 31, 2026 07:35

msonnb mentioned this pull request Jul 31, 2026

feat(nestjs)!: Use function span op for setup & lifecycle handlers #22897

Merged

Base automatically changed from ms/js-3105-middleware-span-op to develop July 31, 2026 11:17

nicohrubec reviewed Jul 31, 2026

View reviewed changes

isaacs approved these changes Jul 31, 2026

View reviewed changes

msonnb force-pushed the ms/js-3105-handler-function-op branch from fa5721f to d78a45b Compare August 4, 2026 08:53

cursor Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread packages/server-utils/src/integrations/tracing-channel/fastify/instrumentation.ts

msonnb marked this pull request as draft August 5, 2026 06:49

msonnb force-pushed the ms/js-3105-handler-function-op branch from d78a45b to d09a042 Compare August 5, 2026 15:35

msonnb changed the title ~~feat!: Use function span op for terminal request handlers~~ feat!: Use handler span op for terminal request handlers Aug 5, 2026

msonnb marked this pull request as ready for review August 5, 2026 16:00

msonnb and others added 4 commits August 6, 2026 11:57

SENTRY_OP

0208e31

use 'handler' instead

9eb802c

msonnb force-pushed the ms/js-3105-handler-function-op branch from d09a042 to 9eb802c Compare August 6, 2026 09:57

Lms24 approved these changes Aug 6, 2026

View reviewed changes

msonnb merged commit 868c7fc into develop Aug 6, 2026
526 of 529 checks passed

msonnb deleted the ms/js-3105-handler-function-op branch August 6, 2026 11:34

This was referenced Sep 16, 2026

publish: getsentry/sentry-javascript@11.0.0-rc.0 getsentry/publish#9545

Closed

publish: getsentry/sentry-javascript@11.0.0 getsentry/publish#9615

Closed

brandhaug mentioned this pull request Sep 27, 2026

chore(deps): bump sentry dependencies brandhaug/b2b-saas-starter#506

Merged

Uh oh!

Conversation

msonnb commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented Jul 30, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

nicohrubec left a comment

Choose a reason for hiding this comment

Uh oh!

isaacs left a comment

Choose a reason for hiding this comment

Uh oh!

isaacs Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

msonnb Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

isaacs Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

isaacs Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

msonnb Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

isaacs Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

msonnb commented Aug 4, 2026

Uh oh!

msonnb commented Aug 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

msonnb commented Jul 30, 2026 •

edited

Loading

github-actions Bot commented Jul 30, 2026 •

edited

Loading