Conversation
…id tanstack router
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where web vitals were not being sent on pageload in the Solid TanStack Router integration. The problem was caused by a conditional check that would short-circuit during initial pageload, preventing the pageload transaction from completing and sending web vitals measurements.
- Updated the navigation span filtering logic to explicitly check for absence of
fromLocationbefore comparing location states - Added comprehensive test coverage to verify web vitals are sent on pageload
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/solid/src/tanstackrouter.ts | Fixed the condition in onBeforeNavigate callback to properly detect initial pageload by checking for absence of fromLocation before comparing location states |
| dev-packages/e2e-tests/test-applications/solid-tanstack-router/tests/routing-instrumentation.test.ts | Added test case to verify pageload transactions include web vitals measurements (ttfb, lcp, fp, fcp) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andreiborza
approved these changes
Dec 17, 2025
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Thanks for taking care of this 🙏
logaretm
deleted the
awad/js-1323-solid-core-web-vitals-arent-reported-with-tanstack-router
branch
December 17, 2025 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted the condition for reporting web vitals previously it would short circuit and prevent them from being reported, I included a test.
similar to what we did in #18463
closes #18540