Skip to content

fix(tracemetrics): Send boolean for internal replay attribute - #17908

Merged
chargome merged 5 commits into
developfrom
cg-metrics-replay-id
Oct 15, 2025
Merged

chargome merged 5 commits into
developfrom
cg-metrics-replay-id

Conversation

@chargome

Copy link
Copy Markdown
Member

Just stumbled upon this, accidentally passed the id instead of a boolean here.

@chargome chargome self-assigned this Oct 10, 2025
@github-actions

github-actions Bot commented Oct 10, 2025 •

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,901 - 8,841 +1%
GET With Sentry 1,380 16% 1,392 -1%
GET With Sentry (error only) 6,222 70% 6,174 +1%
POST Baseline 1,149 - 1,229 -7%
POST With Sentry 519 45% 528 -2%
POST With Sentry (error only) 1,081 94% 1,073 +1%
MYSQL Baseline 3,383 - 3,384 -0%
MYSQL With Sentry 489 14% 479 +2%
MYSQL With Sentry (error only) 2,755 81% 2,743 +0%

View base workflow run

@chargome
chargome requested a review from AbhiPrasad October 13, 2025 09:04
@chargome
chargome enabled auto-merge (squash) October 15, 2025 11:38
@chargome
chargome merged commit e557d38 into develop Oct 15, 2025
191 checks passed
@chargome
chargome deleted the cg-metrics-replay-id branch October 15, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants