fix(react): Import default for hoistNonReactStatics - #15238
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
c298lee
reviewed
Jan 31, 2025
c298lee
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up during upgrading Sentry to our v9 alpha (getsentry/sentry#84258).
Currently our import emits this line in cjs:
hoistNonReactStatics.default(Wrapped, WrappedComponent);Which results in a runtime error (at least in jest runners).
With this change I updated the import to use
import * as hoistNonReactStaticsImport from 'hoist-non-react-statics';which solves the issue but breaks our ts-check. For this I moved the import into a fallback util function which satisfies ts.