Skip to content

sentry v5.14.0, Cannot find name 'Performance' #2494

Description

@hlian

We received a lint error this morning after dependabot tried to upgrade us to v5.14:

node_modules/@sentry/utils/dist/misc.d.ts:90:53 - error TS2304: Cannot find name 'Performance'.

90 export declare const crossPlatformPerformance: Pick<Performance, 'now' | 'timeOrigin'>;

It seems like this interface should be coming from

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/perf_hooks.d.ts

? But misc.ts is assuming it exists in globals.d.ts? I tracked the change to #2485 but it seems like it passed CI, so maybe we just have TypeScript misconfigured? We're on Node v12.16.1 and TypeScript v3.8.3, if that makes a difference.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions