Skip to content

Flush log buffer in base Client.close() #19347

Description

@sergical

Problem

When client.close() is called, the log buffer is not flushed. The close() method in platform SDKs (node-core, deno) only removes the exit event listener but doesn't call _INTERNAL_flushLogsBuffer(this). This means pending logs can be lost if someone explicitly closes the client.

Proposed Solution

Add _INTERNAL_flushLogsBuffer(this) to the base Client.close() in packages/core/src/client.ts so all SDKs benefit automatically, rather than fixing it in each platform SDK individually.

References

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions