Skip to content

On##> ## 馃摙 Type of change聽#17860

Description

@saidmahamed9605-hue

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

fixes: #5180

Metro 0.83.2 changes exports from cjs:module.exports to mjs:export(default).

The named exports should not cause any issue, but modules.exports to export default requires reading .default.

馃挕 Motivation and Context

Since there were multiple changes in recent Metro version I believe vendoring simple modules like countLine will be more stable in the future.

馃挌 How did you test it?

馃摑 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

馃敭 Next steps

Very active

Originally posted by @saidmahamed9605-hue in getsentry/sentry-react-native#5185 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions