Skip to content

Default to internal_error rather than unknown_error when setting error span status #17814

Description

@Lms24

Description

Currently, we have some places in which we default to 'unknown_error' for the span status message if the span status is changed to Error (2). The message has the implication that the Sentry product does not render the span as errored. Therefore we decided to just default to 'internal_error' in all cases, except for a remaining case when determining error state from http response codes. This should make the intention of the 'unknown_error' more clear so that we don't accidentally default to it in the future.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions