@sentry/profiling-node@7.120.4 doesn't use pre build binaries

[AdriVanHoudt]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

7.120.4

Framework Version

/

Link to Sentry event

/

Reproduction Example/SDK Setup

No response

Steps to Reproduce

Clean install @sentry/profiling-node@7.120.4.
We're seeing this mainly on CI using Node 22.18.0 on Linux x64 ubuntu 22 using pnpm 9.15.9.

I suspect that the changes in this PR #17083 caused the install script of profiling-node to be deleted which then makes it force rebuild the binaries.

Locally I've seen it fail differently where it complains to be missing node-gyp completely, which is not the same error exactly but it does feel related. (MacOS 15.6, Node 22.18.0, pnpm 9.15.9)

I can easily PR the install script back if that ends up being the issue.

Expected Result

It used pre build binaries on supported systems

Actual Result

.../node_modules/@sentry/profiling-node install$ node-gyp rebuild
.../node_modules/@sentry/profiling-node install: gyp info it worked if it ends with ok
.../node_modules/@sentry/profiling-node install: gyp info using node-gyp@10.3.1
.../node_modules/@sentry/profiling-node install: gyp info using node@22.18.0 | linux | x64
.../node_modules/@sentry/profiling-node install: gyp info find Python using Python version 3.10.12 found at "/usr/bin/python3"
.../node_modules/@sentry/profiling-node install: gyp http GET https://nodejs.org/download/release/v22.18.0/node-v22.18.0-headers.tar.gz
.../node_modules/@sentry/profiling-node install: gyp http 200 https://nodejs.org/download/release/v22.18.0/node-v22.18.0-headers.tar.gz
.../node_modules/@sentry/profiling-node install: gyp http GET https://nodejs.org/download/release/v22.18.0/SHASUMS256.txt
.../node_modules/@sentry/profiling-node install: gyp http 200 https://nodejs.org/download/release/v22.18.0/SHASUMS256.txt
.../node_modules/@sentry/profiling-node install: gyp info spawn /usr/bin/python3
.../node_modules/@sentry/profiling-node install: gyp info spawn args [
.../node_modules/@sentry/profiling-node install: gyp info spawn args '/home/runner/setup-pnpm/node_modules/.pnpm/pnpm@9.15.9/node_modules/pnpm/dist/node_modules/node-gyp/gyp/gyp_main.py',
.../node_modules/@sentry/profiling-node install: gyp info spawn args 'binding.gyp',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-f',
.../node_modules/@sentry/profiling-node install: gyp info spawn args 'make',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-I',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '/home/runner/_work/loctax/loctax/node_modules/.pnpm/@sentry+profiling-node@7.120.4/node_modules/@sentry/profiling-node/build/config.gypi',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-I',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '/home/runner/setup-pnpm/node_modules/.pnpm/pnpm@9.15.9/node_modules/pnpm/dist/node_modules/node-gyp/addon.gypi',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-I',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '/home/runner/.cache/node-gyp/22.18.0/include/node/common.gypi',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-Dlibrary=shared_library',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-Dvisibility=default',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-Dnode_root_dir=/home/runner/.cache/node-gyp/22.18.0',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-Dnode_gyp_dir=/home/runner/setup-pnpm/node_modules/.pnpm/pnpm@9.15.9/node_modules/pnpm/dist/node_modules/node-gyp',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-Dnode_lib_file=/home/runner/.cache/node-gyp/22.18.0/<(target_arch)/node.lib',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-Dmodule_root_dir=/home/runner/_work/loctax/loctax/node_modules/.pnpm/@sentry+profiling-node@7.120.4/node_modules/@sentry/profiling-node',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-Dnode_engine=v8',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '--depth=.',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '--no-parallel',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '--generator-output',
.../node_modules/@sentry/profiling-node install: gyp info spawn args 'build',
.../node_modules/@sentry/profiling-node install: gyp info spawn args '-Goutput_dir=.'
.../node_modules/@sentry/profiling-node install: gyp info spawn args ]
.../node_modules/@sentry/profiling-node install: gyp info spawn make
.../node_modules/@sentry/profiling-node install: gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
.../node_modules/@sentry/profiling-node install: make: Entering directory '/home/runner/_work/loctax/loctax/node_modules/.pnpm/@sentry+profiling-node@7.120.4/node_modules/@sentry/profiling-node/build'
.../node_modules/@sentry/profiling-node install:   ACTION Regenerating Makefile
.../node_modules/@sentry/profiling-node install: /bin/sh: 1: /home/runner/setup-pnpm/node_modules/.pnpm/pnpm@9.15.9/node_modules/pnpm/dist/node_modules/node-gyp/gyp/gyp_main.py: Permission denied
.../node_modules/@sentry/profiling-node install: make: *** [Makefile:343: Makefile] Error 126
.../node_modules/@sentry/profiling-node install: make: Leaving directory '/home/runner/_work/loctax/loctax/node_modules/.pnpm/@sentry+profiling-node@7.120.4/node_modules/@sentry/profiling-node/build'
.../node_modules/@sentry/profiling-node install: gyp ERR! build error 
.../node_modules/@sentry/profiling-node install: gyp ERR! stack Error: `make` failed with exit code: 2
.../node_modules/@sentry/profiling-node install: gyp ERR! stack at ChildProcess.<anonymous> (/home/runner/setup-pnpm/node_modules/.pnpm/pnpm@9.15.9/node_modules/pnpm/dist/node_modules/node-gyp/lib/build.js:216:23)
.../node_modules/@sentry/profiling-node install: gyp ERR! System Linux 6.8.0-1033-aws
.../node_modules/@sentry/profiling-node install: gyp ERR! command "/opt/hostedtoolcache/node/22.18.0/x64/bin/node" "/home/runner/setup-pnpm/node_modules/.pnpm/pnpm@9.15.9/node_modules/pnpm/dist/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
.../node_modules/@sentry/profiling-node install: gyp ERR! cwd /home/runner/_work/loctax/loctax/node_modules/.pnpm/@sentry+profiling-node@7.120.4/node_modules/@sentry/profiling-node
.../node_modules/@sentry/profiling-node install: gyp ERR! node -v v22.18.0
.../node_modules/@sentry/profiling-node install: gyp ERR! node-gyp -v v10.3.1
.../node_modules/@sentry/profiling-node install: gyp ERR! not ok 
.../node_modules/@sentry/profiling-node install: Failed

[linear]

JS-876 @sentry/profiling-node@7.120.4 doesn't use pre build binaries

[chargome]

Hm I think they were vendored in for a reason with that PR, any idea @andreiborza ?

[andreiborza]

Yea we pre-bundle these so you don't have to install. Where does this happen for you? Need a bit more context, I tried setting up a new project locally with v7 and had no problems.

[mydea]

They where bundled because ubuntu-24.04 cannot build them anymore for all things we support.

What exactly is not working for you @AdriVanHoudt ? Do you want to build them yourself? Ideally everything should continue to work with the built-in binaries, or are you saying they are not being picked up?

[timfish]

v7.120.4 was only published a month ago but it was only a bug fix release. The v7 branch hasn't seen and major changes in over 18 months.

By the time you get to the latest major (v10.9.0), the profiling binaries have moved to another repository and the build system has been improved.

[Lms24]

I'm going to close this because we likely won't fix this in v7. As written above, more recent versions of the SDK should fix this issue. Please let me know if this needs to be reopened.