Repository navigation
sentry.server.config.js fills up with globalThis #17179
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/astro
SDK Version
9.41.0
Framework Version
Astro 5.12.3
Link to Sentry event
No response
Reproduction Example/SDK Setup
https://github.com/johnnydecimal/astro-sentry
Steps to Reproduce
- Run
npm run astro check, or a build. - Check
sentry.server.config.js. - Do it again and watch the
globalThisentries just pile up.
Expected Result
I don't know if we're expecting a single globalThis block there? Presumably it has some purpose? But we definitely aren't expecting them to just be concatenated to the end.
FWIW mine are 350+ lines long each. The file grows out of control real fast.
Actual Result
As above.
Activity
linear commentedon Jul 26, 2025
JS-774 sentry.server.config.js fills up with globalThis
johnnydecimal commentedon Jul 26, 2025
Note that the example repo has
9.42.0but I confirmed that this change occurred at9.41.0.Ah here we go. Commit 726c86842915111bca94d3787bc203ba05cd07e7 introduced this:
sentry-javascript/packages/astro/src/integration/index.ts
Line 184 in 68d7ee4
To my untrained eye it's not checking whether that already exists. Hence every time you just get a new block.
I'd offer to PR this but believe me you don't want my code.
chargome commentedon Jul 28, 2025
@johnnydecimal thanks for reporting!
cc @s1gr1d this comes from the parameterized routes PR I assume?
s1gr1d commentedon Jul 28, 2025
Hello and thanks for raising this. I reverted the changes for now and we will release this as soon as possible.
fix(v9/astro): Revert Astro v5 storing route data to `globalThis` (#1…
s1gr1d commentedon Jul 28, 2025
This is released in 9.42.1.
fix(astro): Construct parametrized route during runtime (#17190)
fix(astro): Construct parametrized route during runtime (#17190)
github-actions commentedon Jul 31, 2025
A PR closing this issue has just been released 🚀
This issue was referenced by PR #17190, which was included in the 10.0.0 release.