OpenTelemetry Express instrumentation does not match Sentry instrumentation

[timfish]

Which SDK are you using?

@sentry/node-experimental

SDK Version

latest

Steps to Reproduce

When adding integration tests for @sentry/node-experimental, I started by using the assertions from the @sentry/node tests.

It looks like:

• transaction for regex routes ends up as just /
• data.url is now the full URL rather than just the path
• Http status code tag is not a number rather than string
• Middleware
  • Descriptions have changed
  • op is gone

I'll add anything else I find!

[mydea]

Good findings!

transaction for regex routes ends up as just /

Hmm, this comes directly from OTEL - not sure if/how we can/want to change this 🤔 what is the actual path that was used in this example?

data.url is now the full URL rather than just the path

I wonder if the OTEL behavior is not more correct there? I see in other places we actually use a full URL there, but not sure what is expected here 🤔 cc @AbhiPrasad ?

Http status code tag is not a number rather than string

Oops, I will fixe this!

Middleware Descriptions have changed & op is gone

Hmm I wonder if we want to/can handle this. can you provide a diff (what it was/became)? Then I can see if we can handle these specifically!

[timfish]

what is the actual path that was used in this example?

It's for this route:

app.get(['/test/arr/:id', /\/test\/arr[0-9]*\/required(path)?(\/optionalPath)?\/(lastParam)?/], (_req, res) => {
  res.send({ response: 'response 4' });
});

Hmm I wonder if we want to/can handle this. can you provide a diff (what it was/became)?

For middlewarre, the Sentry instrumentation:

        spans: [
          expect.objectContaining({
            description: 'corsMiddleware',
            op: 'middleware.express.use',
          }),
        ],

For otel, the descriptions have changed like this, op has become origin?

              expect.objectContaining({
                description: 'middleware - corsMiddleware',
                origin: 'auto.http.otel.express',
              }),

[mydea]

For middlewarre, the Sentry instrumentation:

        spans: [
          expect.objectContaining({
            description: 'corsMiddleware',
            op: 'middleware.express.use',
          }),
        ],

For otel, the descriptions have changed like this, op has become origin?

              expect.objectContaining({
                description: 'middleware - corsMiddleware',
                origin: 'auto.http.otel.express',
              }),

I'd say the description is OK (it's different, but not wrong - this comes from otel directly).
Origin is "additionally", this is unrelated to that, so alright there. I guess the main issue is the missing op 🤔 I'll take a look if I can add this somehow to keep the op in there!

[AbhiPrasad]

Given it seems like OTEL totally drops the ball with paramaterizing with multiple routers, we might have to combine the OTEL integration with ours 😢 (so that we can support multiple routers and dont regress too heavily).

Alternative is that we export an integration that just supports multiple routers, and then people opt-into that, but its not the best UX.

ref #9885

[mydea]

After moving tests over to the new node, we noticed that actually our express router tests are passing, but only in node 16+. Somehow, on Node 14 multi router support does not fully work, but since Node 16 it seems to work :O Which I guess is fine, we will document this.