Skip to content

ref(android): Bound Nav3 argument payload size + report argument drop reasons - #6218

Open
0xadam-brown wants to merge 2 commits into
mainfrom
ref/sentry-nav-effect-performance
Open

0xadam-brown wants to merge 2 commits into
mainfrom
ref/sentry-nav-effect-performance

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

📜 Description

PR makes three refinements to how our Nav3 integration handles host-app provided arguments:

  1. Limits the total argument characters sanitized from one back-stack update so large strings and stringified values cannot dominate navigation telemetry payloads or processing time.

  2. Attaches a dropped reason marker when arguments are omitted for performance or safety reasons.

  3. Reduces some of our argument limits in response to benchmark testing results.

💡 Motivation and Context

Addresses @markushi's helpful comment here + lets us incorporate findings from sample app benchmark testing.

addresses: JAVA-274

Screenshots

Back stack context

backstack-context

Breadcrumb

breadcrumb

Span arguments

argument

💚 How did you test it?

Unit tests.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

… reasons

Commit makes three refinements to how our Nav3 integration handles host-app provided arguments:

1. Limits the total argument characters sanitized from one back-stack update so large strings and stringified values cannot dominate navigation telemetry payloads or processing time.

2. Attaches a dropped reason marker when arguments are omitted for performance or safety reasons.

3. Reduces some of our argument limits in response to benchmark testing results.
@sentry

sentry Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.59.0 (1) release

⚙️ sentry-android Build Distribution Settings

@0xadam-brown 0xadam-brown added the sanity-check PR needs a lightweight review for obvious issues label Oct 5, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5563cb. Configure here.

…k stack context + drop visually redundant "arguments_" prefix from drop reason
@0xadam-brown
0xadam-brown force-pushed the ref/sentry-nav-effect-performance branch from f5563cb to d42fc93 Compare October 5, 2026 08:21
@0xadam-brown

Copy link
Copy Markdown
Member Author

Replacing "arguments" key with "entry_arguments" in relevant unit tests to match updated implementation; otherwise unchanged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sanity-check PR needs a lightweight review for obvious issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant