Add the ability to attach on hard crash only

Users have the use case of attaching files only when a hard crash happens (i.e: UncaughtExceptionHandler).

For example: User throws ParseException which has the path to a file that failed parsing.
Currently there's no way to hook into processing that exception in a way that we can add that file as an attachment.

Request came from Discord.

Is there any update on this? I still need it, but of course can look into alternative solutions if it's not going to be implemented. I am just not sure if I should wait or not.

@Nohus

@Nohus we intend to work on it and it's in our backlog, but it's not prioritized yet.

Suggestion for implementation that would have to be discussed with Client Infra TSC as this might be something all SDKs should do. If so the SDKs should do it in a similar manner.

Add a new method to EventProcessor that allows people to extract attachments from an exception.
public List<Attachment> extractAttachments(SentryEvent event)

Default implementation could be added to return an empty list.

@adinauer

@adinauer Should we move this issue to In progress and add to v6? or the hints improvements won't automatically fix this? Thanks.

Closing as use case is supported by #2046

Closing as use case is supported by #2046

🎉 Amazing. I just wish I knew it was possible since May. 😄

@Nohus

@Nohus sorry, forgot to update the issue after merging the PR(s). This test shows how you can add an attachment in beforeSend:

sentry-java/sentry/src/test/java/io/sentry/SentryClientTest.kt

Lines 1724 to 1728 in b3704c8

    
           options.setBeforeSend { event, hints -> 
        
               assertEquals(listOf(fixture.attachment, fixture.attachment2), hints.attachments) 
        
               hints.addAttachment(fixture.attachment3) 
        
               event 
        
           }

Navigation Menu

Repository navigation

Add the ability to attach on hard crash only #1467

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	options.setBeforeSend { event, hints ->
	assertEquals(listOf(fixture.attachment, fixture.attachment2), hints.attachments)
	hints.addAttachment(fixture.attachment3)
	event
	}

Add the ability to attach on hard crash only #1467

Description

Activity

Nohus commented on Sep 7, 2021

marandaneto commented on Sep 8, 2021

adinauer commented on Apr 28, 2022

marandaneto commented on May 11, 2022

adinauer commented on Dec 28, 2022

Nohus commented on Dec 28, 2022

adinauer commented on Dec 29, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions