Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
adinauer
left a comment
There was a problem hiding this comment.
Mostly LGTM, just one comment
| ApolloClient apollo = SentryApolloBuilderExtensionsKt.sentryTracing( | ||
| new ApolloClient.Builder(), | ||
| true, | ||
| Collections.singletonList(SentryOptions.DEFAULT_PROPAGATION_TARGETS), |
There was a problem hiding this comment.
m: DEFAULT_PROPAGATION_TARGETS is marked internal. We could just provide a custom list as sample here or hard code the .* value. Or we open up the default constant.
There was a problem hiding this comment.
Actually, i think i'll remove it. Since we don't show that parameter in the apollo-4 docs or in the kotlin version of this one. WDYT?
There was a problem hiding this comment.
actually, that is an issue in the apollo-4 docs. have a list of issues with the apollo3 and 4 docs, that get their own issue and pr. Went with ".*"
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
|
The plan checks new Apollo 5 page loads and existing Apollo page loads. Services: Mention PlanWhat changedRequests to RiskA bad MDX file can fail static generation for the new paths. Intended effectThe new paths start to record page loads.
Regression watchThis change can break sibling Apollo pages and other pages in the same path families.
Not observablePageload span searches by transaction name returned no rows. |
|
|
||
| <Alert> | ||
|
|
||
| To capture transactions, first <PlatformLink to="/tracing/">set up tracing</PlatformLink>. |
There was a problem hiding this comment.
Are we still using the term "transactions" for this type of data?
|
|
||
| <Alert> | ||
|
|
||
| To capture transactions, first <PlatformLink to="/tracing/">set up tracing</PlatformLink>. |
There was a problem hiding this comment.
Same question about transactions
sfanahata
left a comment
There was a problem hiding this comment.
Looks good from a formatting and general content perspective. Will leave to the experts on when it's ready to merge and accuracy.
DESCRIBE YOUR PR
Docs for the apollo5 integration implemented in getsentry/sentry-java#6074
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.