Repository navigation
feat(attributes): Add allowWildcard to search aliases - #661
Draft
nsdeschenes wants to merge 3 commits into
Draft
nsdeschenes wants to merge 3 commits into
nsdeschenes wants to merge 3 commits into
Conversation
Search can opt individual string attributes out of wildcard queries. The flag defaults to true and is rejected on non-string types. Co-authored-by: Cursor <cursoragent@cursor.com>
IDs, release, and device class are exact-match keys, so wildcard queries on their search aliases are not useful. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Op
Other
🤖 This preview updates automatically when you update the PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowWildcardflag on search aliases so string attributes can opt out of wildcard queries. It defaults to true and is rejected on non-string types.id,device.class,profile.id,profiler.id,release, andreplay.id.Description
Search aliases can now set
allowWildcard: falseto disable wildcard queries. Identifier-style aliases opt out because partial matches are not useful there.PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)If an attribute was deprecated:
Test plan
yarn testyarn generateis a no-op against this branchallowWildcard: falseonly for the opted-out aliases, and omits it everywhere elseMade with Cursor