Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Default code owners
# Default code owners
* @getsentry/owners-ingest

# Legal
/LICENSE @getsentry/owners-legal

# Build & Releases
/.github/workflows/release.yml @getsentry/releases
/.github/workflows/release*.yml @getsentry/releases

Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: Release

on:
workflow_dispatch:
inputs:
Expand All @@ -8,19 +9,23 @@ on:
force:
description: Force a release even when there are release-blockers (optional)
required: false

schedule:
# We want the release to be at 9-10am Pacific Time
# We also want it to be 1 hour before the on-prem release
- cron: "0 17 15 * *"

jobs:
release:
runs-on: ubuntu-latest
name: "Release a new version"
name: "Release a new Relay version"

steps:
- uses: actions/checkout@v2
with:
token: ${{ secrets.GH_RELEASE_PAT }}
fetch-depth: 0

- name: Prepare release
uses: getsentry/action-prepare-release@v1
env:
Expand Down
31 changes: 31 additions & 0 deletions .github/workflows/release_library.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Release Library

on:
workflow_dispatch:
inputs:
version:
description: Version to release
required: true
force:
description: Force a release even when there are release-blockers (optional)
required: false

jobs:
release:
runs-on: ubuntu-latest
name: "Release a new librelay version"

steps:
- uses: actions/checkout@v2
with:
token: ${{ secrets.GH_RELEASE_PAT }}
fetch-depth: 0

- name: Prepare release
uses: getsentry/action-prepare-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GH_RELEASE_PAT }}
with:
version: ${{ github.event.inputs.version }}
force: ${{ github.event.inputs.force }}
path: py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not parametrize the main release action instead?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feared that this would be too error prone. One is CalVer, the other one requires a version. One is released on schedule, the other only ever manually.

They do look quite similar, though.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we can set CalVer automatically and disable if path exists but I'm not sure if the complexity is worth it at this point. Maybe we can have the duplication until we have more then?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, let's go ahead with the current patch then. Thanks!

2 changes: 1 addition & 1 deletion py/.craft.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
minVersion: "0.13.2"
minVersion: "0.16.1"
github:
owner: getsentry
repo: relay
Expand Down