fix(plugins): record all native fallback manifests of a source - #191
Open
adityaanikam wants to merge 1 commit into
Open
adityaanikam wants to merge 1 commit into
adityaanikam wants to merge 1 commit into
Conversation
|
@adityaanikam is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the fallback parsing behavior and extend the regression test through runtime manifest writing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Fixes handling of plugin sources with multiple native fallback manifests by preserving all fallbacks and validating their provenance.
Changes:
- Collects all native fallback manifests while preserving primary priority.
- Supports multiple fallback sources in provenance markers.
- Adds dual-manifest discovery, installation, and reload coverage.
| File | Summary |
|---|---|
packages/dotagents/src/plugins/store.ts |
Updates fallback discovery and provenance validation; malformed non-primary fallbacks may still abort discovery. |
packages/dotagents/src/plugins/store.test.ts |
Adds dual-manifest regression coverage; does not yet exercise runtime manifest writing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
914
to
919
| @@ -915,21 +918,21 @@ async function loadPluginInterfaces( | |||
| } catch (err) { | |||
| throw pluginManifestError(err, value); | |||
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190
When a plugin source has no root plugin.json but ships more than one
native manifest (for example .codex-plugin and .claude-plugin),
loadPluginInterfaces returned after the first match. Only that client
was recorded as an authored native interface, so the other manifest
was treated as unauthored and dotagents warned about an unmanaged
manifest when writing runtime files.
The loop now collects every native fallback manifest. The first match
in the existing priority order is still the primary manifest and
nativeSource, so single-manifest sources behave as before.
readInstalledPluginProvenance rejected any installed bundle whose
fallback marker listed more than one source while a native source
marker was present. That check now only requires the native source to
be one of the recorded fallbacks, otherwise reinstalling or reloading
a dual-manifest bundle would fail.
Adds a regression test covering discovery, install and reload of a
codex plus claude source. Verified on Linux (Node 24, pnpm 10.28.2):
plugins/store.test.ts passes 51/51 with the fix, and the new test
fails without it.