-
-
Notifications
You must be signed in to change notification settings - Fork 165
feat(website): route all Discord links through getopenscreen.com/discord #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <title>OpenScreen Discord</title> | ||
| <!-- | ||
| Single source of truth for the community invite. Every repo and site link | ||
| points at /discord, so rotating or expiring the invite only means editing | ||
| the URL below. GitHub Pages cannot serve real 301s; this meta refresh is | ||
| the supported equivalent. | ||
| --> | ||
| <meta http-equiv="refresh" content="0; url=https://discord.gg/WAqYMxdV8K" /> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Keep the invite URL in one source. The invite is copied into the meta refresh, canonical link, fallback anchor, and JavaScript. A partial invite rotation can make these destinations disagree. Generate this page from one Also applies to: 13-13, 16-16, 18-18 🤖 Prompt for AI Agents |
||
| <link rel="canonical" href="https://discord.gg/WAqYMxdV8K" /> | ||
| </head> | ||
| <body> | ||
| <p>Redirecting to the OpenScreen Discord… If nothing happens, <a href="https://discord.gg/WAqYMxdV8K">join here</a>.</p> | ||
| <script> | ||
| location.replace("https://discord.gg/WAqYMxdV8K"); | ||
| </script> | ||
| </body> | ||
| </html> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Add same-package tests for both changed Discord URL consumers.
website/docusaurus.config.ts#L11: Assert thatDISCORD_URLreaches thesameAsdata and navbar link ashttps://getopenscreen.com/discord.website/src/theme/Footer/index.tsx#L51: RenderFooterand assert that its Discord link useshttps://getopenscreen.com/discord.As per coding guidelines, add a test for every new behavior in the same package as the code under test.
📍 Affects 2 files
website/docusaurus.config.ts#L11-L11(this comment)website/src/theme/Footer/index.tsx#L51-L51🤖 Prompt for AI Agents
Source: Coding guidelines