fix(build): declare all 13 supported locales in the AppX package - #263
Merged
Conversation
The appx manifest advertised en-US and fr-FR only, so the Microsoft Store product page listed two supported languages for an app that ships thirteen (SUPPORTED_LOCALES in src/i18n/config.ts), and the listing never surfaced in Store searches run in the other eleven. Bare tags for the region-less locales so every region of that language matches, which is what the renderer's own locale resolution does.
📝 WalkthroughWalkthroughThe AppX language configuration now declares all 13 application-supported locales instead of only ChangesAppX locale configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
electron-builder.json5declaredappx.languages: ["en-US", "fr-FR"], but the app ships 13 locales (SUPPORTED_LOCALESinsrc/i18n/config.ts: en, ar, es, fr, it, ja-JP, ko-KR, ru, tr, vi, pt-BR, zh-CN, zh-TW).Two consequences on the Microsoft Store product page:
Found while finishing the Store submission for product
9MXQ1HQJL5G5, where 11 additional listing languages had been added that the package itself never claimed to support.Change
appx.languagesnow mirrorsSUPPORTED_LOCALES. Region-less locales use bare tags (ar,es,it,ru,tr,vi) so every region of that language matches — the same resolution the renderer's own loader does.en-USandfr-FRare left as they were, since the Store already has validated listings under those exact tags.Verification
Parsed the edited file with
json5and diffed the two lists: 13/13 locales covered, none missing.No test added: this is a declarative list, not logic. The tie to
src/i18n/config.tsis named in a comment above the array so the next locale addition has a pointer.Note
Config-only — it takes effect on the next
npm run build:win:store, not on the 1.8.0 appx currently sitting in the draft submission.Summary by CodeRabbit