Skip to content

fix(build): declare all 13 supported locales in the AppX package - #263

Merged
EtienneLescot merged 1 commit into
release/v1.9.0from
fix/appx-declare-all-locales
Aug 4, 2026
Merged

fix(build): declare all 13 supported locales in the AppX package#263
EtienneLescot merged 1 commit into
release/v1.9.0from
fix/appx-declare-all-locales

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Problem

electron-builder.json5 declared appx.languages: ["en-US", "fr-FR"], but the app ships 13 locales (SUPPORTED_LOCALES in src/i18n/config.ts: en, ar, es, fr, it, ja-JP, ko-KR, ru, tr, vi, pt-BR, zh-CN, zh-TW).

Two consequences on the Microsoft Store product page:

  • it advertises "supported languages: English, French" for an app translated into 13;
  • the listing never surfaces in Store searches run in the other 11 languages.

Found while finishing the Store submission for product 9MXQ1HQJL5G5, where 11 additional listing languages had been added that the package itself never claimed to support.

Change

appx.languages now mirrors SUPPORTED_LOCALES. Region-less locales use bare tags (ar, es, it, ru, tr, vi) so every region of that language matches — the same resolution the renderer's own loader does. en-US and fr-FR are left as they were, since the Store already has validated listings under those exact tags.

Verification

Parsed the edited file with json5 and diffed the two lists: 13/13 locales covered, none missing.

appx.languages (13): en-US, fr-FR, ar, es, it, ja-JP, ko-KR, pt-BR, ru, tr, vi, zh-CN, zh-TW
SUPPORTED_LOCALES (13): en, ar, es, fr, it, ja-JP, ko-KR, ru, tr, vi, pt-BR, zh-CN, zh-TW
not covered by appx: none

No test added: this is a declarative list, not logic. The tie to src/i18n/config.ts is named in a comment above the array so the next locale addition has a pointer.

Note

Config-only — it takes effect on the next npm run build:win:store, not on the 1.8.0 appx currently sitting in the draft submission.

Summary by CodeRabbit

  • Improvements
    • Expanded Microsoft Store language support to include all 13 available application locales.

The appx manifest advertised en-US and fr-FR only, so the Microsoft Store
product page listed two supported languages for an app that ships thirteen
(SUPPORTED_LOCALES in src/i18n/config.ts), and the listing never surfaced in
Store searches run in the other eleven.

Bare tags for the region-less locales so every region of that language
matches, which is what the renderer's own locale resolution does.
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The AppX language configuration now declares all 13 application-supported locales instead of only en-US and fr-FR.

Changes

AppX locale configuration

Layer / File(s) Summary
Expand AppX locale declarations
electron-builder.json5
The appx.languages list now includes 13 regional and bare language tags.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: siddharthvaddem

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the primary configuration change: adding all 13 supported locales to the AppX package.
Description check ✅ Passed The description clearly states the problem, change, verification, and release timing, although it does not use all template headings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/appx-declare-all-locales

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot changed the base branch from main to release/v1.9.0 August 4, 2026 22:25
@EtienneLescot
EtienneLescot merged commit f02696d into release/v1.9.0 Aug 4, 2026
17 checks passed
@EtienneLescot
EtienneLescot deleted the fix/appx-declare-all-locales branch August 4, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant