Lower follow-up composer control emphasis - #2529
Open
brsbl wants to merge 2 commits into
Open
Conversation
brsbl
force-pushed
the
bb/lower-composer-control-emphasis-thr_sjdd7gudiq
branch
from
August 27, 2026 07:15
b0cadd8 to
f048e1c
Compare
brsbl
changed the base branch from
bb/thr_fdabesxhdr
to
bb/fix-misleading-host-disconnect-reason-thr_sjdd7gudiq
August 27, 2026 07:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Secondary follow-up composer affordances used three different foreground tiers: the plus action inherited the primary foreground, the model caret used the muted foreground, and the collapse caret used the subtle foreground. That inconsistency gave low-priority chrome more visual weight than its function warranted and made the controls compete with the selected model and prompt content.
What changed
text-subtle-foreground/75tier only when the picker uses its muted composer presentation; non-composer picker styling is unchanged.Control emphasisLadle state without the overview story's comparison-label column.Before — parent PR head
f434d3f44c537a8ef943f4d4f8cc20db3ac86602The plus action, model caret, and collapse caret render at three stronger, inconsistent foreground tiers.
After — child head
7b7f9c645bf88916298e664c444110df18cd2ff3All three affordances use the same lower-emphasis chrome tier while model text and primary actions retain their hierarchy.
How you verified
foregroundfor plus,muted-foregroundfor the model caret, andsubtle-foregroundfor collapse. They pass at the child head with all three resolving tosubtle-foreground/75.pnpm exec turbo run test --filter=@bb/app --force -- src/components/promptbox/PromptBoxInternal.test.tsx src/components/promptbox/PromptBoxActionsMenu.test.tsx src/components/pickers/ModelReasoningPicker.test.tsx— 144/144 tests passed.pnpm exec turbo run typecheck --filter=@bb/apppassed on the final head.pnpm exec turbo run lint --filter=@bb/appcompleted with 0 errors; existing repository warnings remain.oxfmt --checkandgit diff --checkpassed.BB-Thread-ID: thr_sjdd7gudiq