Repository navigation
Conversation
Prometheus instances managed by the Operator ignore scrape annotations. Add a Service and ServiceMonitor template and document the cluster-specific values to adjust. Add a note on securing the unauthenticated /metrics endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
documentation/kubernetes/servicemonitor.yaml: Service with a named port plus ServiceMonitor. Comments list the values to adjust per cluster (namespace, pod selector,releaselabel, scrape path withGEOSPATIAL_ANALYZER_URL_PREFIX).documentation/metrics.md: new sections "Prometheus Operator Configuration" and "Securing the Endpoint". The opening sentence in "Kubernetes Configuration" now clarifies that the annotations only apply without the Operator.Review note
The first commit only applies Prettier formatting to
metrics.mdSide finding, not part of this PR: when a URL prefix is set, the metrics interceptor counts
/metricsscrapes as regular requests (Issue #249).