Repository navigation
The library facade takes its core modules from where they went - #701
Merged
Merged
Conversation
src/trinity.zig imported bigint.zig, packed_trit.zig, hybrid.zig and vsa/core.zig -- four files that 42490a2 moved into gHashTag/zig-hdc and gHashTag/zig-golden-float without moving the references. It is the library root, so three separate targets root it and all three failed. The aliasing was decided by a symbol test rather than by names, and the names would have led the wrong way: golden-float exports `bigint`, and that name points at its ternary/hybrid.zig, while the actual big-integer module is exported as `ternary_primitives`. Checked against every re-export in this file, zig-hdc's vsa module carries all sixteen VSA names, golden-float carries TVCBigInt, PackedBigInt, HybridBigInt, Trit, MAX_TRITS and TRITS_PER_BYTE. vsa/agent.zig is not re-exported any more. Its five parts have never been tracked here and are not in zig-hdc either, where the same facade was withdrawn last night. Nothing in this file referenced vsa_agent, so this removes a name nobody could resolve rather than a capability anybody had. Reachable missing files drop from thirteen to ten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/trinity.zigimportedbigint.zig,packed_trit.zig,hybrid.zigandvsa/core.zig— four files that 42490a2 moved into gHashTag/zig-hdc and gHashTag/zig-golden-float without moving the references. It is the library root, so three targets root it and all three failed.The aliasing was decided by a symbol test, and the names would have led the wrong way: golden-float exports
bigint, and that name points at itsternary/hybrid.zig, while the actual big-integer module is exported asternary_primitives.Checked against every re-export in the file:
bind…vectorNorm)zig-hdc-vsaTVCBigIntgolden_float.ternary_primitivesPackedBigIntgolden_float.packed_tritHybridBigInt,Trit,MAX_TRITS,TRITS_PER_BYTEgolden_float.bigint(which is hybrid)vsa/agent.zigis no longer re-exported. Its five parts have never been tracked here and are not in zig-hdc either, where the same facade was withdrawn last night. Nothing referencedvsa_agent— this removes a name nobody could resolve, not a capability anybody had.Reachable missing files: 13 → 10.