Repository navigation
Fix what the gallery said about me, and say that it is fixed - #663
Merged
Merged
Conversation
The page published a count against myself: four of my five chips declared their sources incompletely or not at all, against five of five other people's that got it right. Leaving that unfixed once public would be worse than never looking. MINI and HOLO now declare their source file (trinity-fpga ffcf8fb5); Phi and Gamma were fixed when the defect was found. The score line says the count WAS 5 to 1 and that all four are repaired, rather than reading as though the problem had not existed. Two cards also gained a caveat that should have been there: config.json marks MINI and HOLO a skeleton, and 49 and 128 cells agree. Listing a skeleton beside finished designs without saying so overstates it.
github-actions Bot
added a commit
that referenced
this pull request
Aug 10, 2026
Fix what the gallery said about me, and say that it is fixed (#663) The page published a count against myself: four of my five chips declared their sources incompletely or not at all, against five of five other people's that got it right. Leaving that unfixed once public would be worse than never looking. MINI and HOLO now declare their source file (trinity-fpga ffcf8fb5); Phi and Gamma were fixed when the defect was found. The score line says the count WAS 5 to 1 and that all four are repaired, rather than reading as though the problem had not existed. Two cards also gained a caveat that should have been there: config.json marks MINI and HOLO a skeleton, and 49 and 128 cells agree. Listing a skeleton beside finished designs without saying so overstates it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page published a count against myself — four of my five chips declared their sources incompletely or not at all, against five of five other people's that got it right. Leaving that unfixed once public would be worse than never having looked.
MINI and HOLO now declare their source file (trinity-fpga#520,
ffcf8fb5); Phi and Gamma were fixed when the defect was found. The score line says the count was 5 to 1 and that all four are repaired.Two cards also gained a caveat that should have been there from the start:
src/config.jsonmarks MINI and HOLO a skeleton — "full RTL implementation is a future wave" — and their 49 and 128 cells agree. Listing a skeleton beside finished designs without saying so overstates it.