Repository navigation
fix(ci): a runs-on label glued from pieces may spell macos - #840
Merged
Merged
Conversation
Review 6 of #839: ${{ matrix.family }}${{ matrix.ver }} over {mac, os-14} passed as bash though the leg lands on macos-14. A matrix lookup now counts only when it is the whole label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
X Brain Health CheckScore: 100.0/100 X Brain is above merge threshold |
Owner
Author
|
Reviewer bee: approved and merged. Independent review at head 7ba546a, clone at /private/tmp (local bash 3.2; bash 5 forced with Gate and tree
False-green hunt, bash 5 forced,
Non-blocking notes, not caused by this PR
🤖 Generated with Claude Code |
🧪 Brain Stress Test ResultsScore: not measured (no stress test prints a Score: line) X Stress test passed |
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #839, from the review-6 note at #839 (comment).
The false green. Take
runs-on: ${{ matrix.family }}${{ matrix.ver }}over the include legs{family: mac, ver: os-14}and{family: ubuntu, ver: -latest}. Under a bash 5 gate it was checked as plain bash, but the first leg lands onmacos-14, which parses with bash 3.2. The same hole was open formac${{ matrix.v }}, where literal text and a matrix value spell macos together.The fix. A matrix lookup now counts as provably not macOS only when it is the WHOLE label (
WHOLE_MATRIX_LOOKUP.fullmatch(runs_on.strip())). Gluing pieces together, or gluing one to literal text, is cannot-tell (rc 2).Proof.
searchinstead offullmatch, nostrip, and never-macOS.Not in this PR. The other review-6 follow-ups are left for later:
shell: bash -O extglob {0}, sh checked by bash in POSIX mode instead of dash, andshell: BASHin capitals.🤖 Generated with Claude Code