Repository navigation
gen-zig: a unary operator keeps its operand whole; -(a + b) no longer runs as -a + b (Closes #6549) - #8986
Merged
Conversation
… runs as -a + b (Closes #6549) Owner-approved hotfix of the frozen compiler: the owner (Architect) said "fix everything" on 2026-10-11, which is the Architect approval FROZEN.md section 5 step 2 asks for. The parser keeps no parenthesis node, and gen-zig wrote a unary operator straight in front of its operand. So -(a + b) ran as -a + b, !(a and b) as !a and b, and ~(a | b) as ~a | b, with typecheck green. The operand now goes through gen_expr_maybe_paren, which parenthesizes a binary operand. The Verilog, C and Rust emitters already parenthesize; only gen-zig had it. -(-a) emits --a, which Zig reads as double negation (checked, zig 0.16). Seal: bootstrap/stage0/FROZEN_HASH old 465abf513dc2e6dd805f7765a87aea1d31b1821473b2f1336f331978bef38a2d new 9795307e5869acf76fe406fa19a170bac05da4b539f6529b707fc59dc78a8fca cargo test --release in bootstrap/ (zig 0.16 on PATH): 138 binaries, 2988 passed, 9 failed, 2 ignored, identical to master 5d9c0c1 with the same 9 failures. No Rust test added; the regression case is a .t27 spec. Blast radius (2237 tracked specs, gen / gen-verilog / gen-rust / gen-c, t27c from master vs this branch): the Zig of 20 existing specs changed; no Verilog, C or Rust changed; no spec moved between generating and not. test-report on the 20: no pass/fail move. 7 pass on both sides, 13 stay blocked by unrelated compile errors. tri seals drift --fix re-sealed the 17 that carry seals (27 files with twins); drift is 0 after. Regression: specs/compiler/codegen_conformance.t27, 0/3 on master, 3/3 here. Hand-written Rust: +1 -1 (net 0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
gHashTag
enabled auto-merge (squash)
October 11, 2026 08:54
gHashTag
pushed a commit
that referenced
this pull request
Oct 11, 2026
Master fixed the unary-operand parens independently (#6549, #8986), with its own conformance spec. This branch keeps master's line in compiler.rs and drops its own duplicate test from bare_semicolon_zig.rs. FROZEN_HASH follows the merged compiler.rs. Conflicting seals were taken from master and then re-sealed against the merged compiler. Over all 1865 specs, gen differs from master's t27c for 37 specs: the exp/log/sin/cos/tanh lowering and the bench-clock notice. None of them is specs/ternary/trits.t27 or radix_economy.t27. For those 37, test-report moves only forward, and check_seal_currency reports 0 stale seals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
This was referenced Oct 11, 2026
gHashTag
added a commit
that referenced
this pull request
Oct 11, 2026
…9073) The last gen-drift seals on master. queen_QueenHolds raced #9028 (gen-rust); policy_PolicyIssueShape was sealed by t27c 0.5.0 in #9059, before #8986, #8991 and #9028 changed its Zig, Verilog and Rust output. Re-saved with master b0b6569's t27c on the Railway lab. Spec hashes are unchanged. check_seal_currency and check_seal_coverage both pass after it. Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6549
Owner-approved hotfix of the frozen compiler. The owner (Architect) said "fix everything" on 2026-10-11. That is the Architect approval FROZEN.md section 5 step 2 asks for, so
bootstrap/src/compiler.rsand its seal move in this PR.Root cause
The parser keeps no parenthesis node, and gen-zig wrote a unary operator straight in front of its operand (
self.gen_expr). So-(a + b)ran as-a + b,!(a and b)as!a and b, and~(a | b)as~a | b, with typecheck green. The t27o agent reported the!(...)form (see #8971).Fix
The operand goes through
gen_expr_maybe_paren, which parenthesizes a binary operand. This is one changed line. The Verilog, C and Rust emitters already parenthesize; only gen-zig had the defect.-(-a)still emits--a, which Zig 0.16 reads as a double negation (checked).Freeze ceremony
465abf513dc2e6dd805f7765a87aea1d31b1821473b2f1336f331978bef38a2d9795307e5869acf76fe406fa19a170bac05da4b539f6529b707fc59dc78a8fca(from master's ownt27c frozen-digest)cargo test --release(bootstrap/, zig 0.16 on PATH), master 5d9c0c1Blast radius
Measured on the t27c lab over 2237 tracked specs (
git ls-files '*.t27'minus specs/scratch),gen,gen-verilog,gen-rustandgen-c, with t27c built from master and from this branch:t27c test-reporton those 20: no pass/fail move. 7 run and pass on both sides: gf16 201/201, d_f19_test 16/16, trios-sacred SC-01 3/3, t27b comptime_float 4/4, comptime_float_f128 7/7, repeat_addr_unreached 1/1, verilog_emit 5/5. 13 stay blocked by unrelated compile errors, binary_crossentropy_loss among them (use of undeclared identifier 'new', line 135).-(x * y)(gf16, SC-01, comptime_float_f128),~(1 << k)masks (bitmap, bitvector, ternary_memory),!(p or q)guards (pins/parser, security, dedupe_identical_tests, feed_untested, trinity_fpga_adapter, verilog_emit, comptime_float, variant, gf16_matmul_top),&(.{} ** n)(pubsub, lsp/protocol, d_f19_test, repeat_addr_unreached) and the loss gradient in binary_crossentropy_loss.tri seals drift --fixre-sealed the 17 that carry seals (27 files with twins). After it, drift is 0,check_seal_coverage.pypasses, andcheck_seal_currency.pyreports 0 stale.compiler_CodegenConformance.jsonis new.Regression case
specs/compiler/codegen_conformance.t27is one conformance spec for reference-path miscompiles. Later cases are added to it, not to a spec per bug (#8963). It has three tests: unary minus over a sum,!over a conjunction, and~over a disjunction. They fail 0/3 on master and pass 3/3 here.Gates
check_budgetandcheck_allfrom master'sgen/c/policy/own_language.cboth exit 0.tri hooks pre-commitandtri hooks commit-msgpass.check_duplicate_declarations.pypasses.🤖 Generated with Claude Code