Repository navigation
fix: repo-relative t27a seals + parseable orbitofrontal_value port (master red gates) - #6861
Merged
Merged
Conversation
- .trinity/seals/{isa_T27a,isa_Tri27Encoding,theory_CompilerTheoryIsaRoundTrip}.json
(from #6789) stored spec_path as an absolute local worktree path, so
seal-coverage could not find the specs on the lab. spec_path is now
repo-relative like every other seal. All seal hashes are content-only
(spec_hash re-checked against the current specs), so only the path
changes.
- specs/port/trinity/src/brain/orbitofrontal_value.t27 (from #6755) did not
parse: a `switch` with `.tag => { ... }` block arms hits "Unexpected token
in expression: LBrace". The four arms are rewritten as an if / else-if
chain over the enum tag with the same values; tests unchanged.
Refs #6507
Refs #6488
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 6, 2026 13:49
This was referenced Oct 6, 2026
Merged
Contributor
This was referenced Oct 6, 2026
Open
Merged
Merged
ci(t27b): native arm64 t27b tests and corpus ratchet per PR; tri t27b ready reads them (#6444)
#6846
Merged
Merged
This was referenced Oct 6, 2026
feat(crm-story-reel): v26 the owner's own reel may name the house, every end card has a ground
#6880
Merged
Open
Merged
Master's #6862 already resealed the three t27a seals with repo-relative paths; take master's copies. Only the orbitofrontal_value.t27 parse fix remains in this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 6, 2026
Closed
Contributor
PR DashboardGenerated at: 2026-10-06 14:57:57 UTC
Summary
Seal Status
|
This was referenced Oct 6, 2026
Merged
Merged
gHashTag
added a commit
that referenced
this pull request
Oct 6, 2026
The branch sat on #6894's base, which predates #6861 (parseable orbitofrontal_value port); the lab's specs-generate and suite ratchet were red on that inherited spec only. Conflict in foreign-exceptions.txt: both sides kept. Published figures re-pinned to the merged corpus: test blocks 15697 (master 15684 at 31ad9df + #6894 8 + #6940 5), x.len 2149 (master +2). Refs #6940 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Master is red on the t27c Railway lab in three gates (
suite,specs-generate,seal-coverage) since two merges:feat(isa): t27a MVP -- TRI-27 assembler/disassembler round-trip (Refs #6507) #6789 committed three seals whose
spec_pathis an absolute local worktree path (/Users/.../worktrees/agent-.../specs/...) instead of a repo-relative one:.trinity/seals/isa_T27a.json.trinity/seals/isa_Tri27Encoding.json.trinity/seals/theory_CompilerTheoryIsaRoundTrip.jsonOn the lab that path does not exist, so
seal-coveragereports "3 seal(s) newly do not hold".Port gHashTag/trinity:src/brain/orbitofrontal_value.zig (Zig, 2 functions) to specs/port/trinity/src/brain/orbitofrontal #6755 added
specs/port/trinity/src/brain/orbitofrontal_value.t27, which does not parse: aswitchwith block arms (.gf16 => { ... },) fails withUnexpected token in expression: LBrace ('{') at line 96:18. That one spec failsspecs-generate(gen_hash=none) and the suite ratchet (1 unexpected[parse]failure).Fix
spec_pathlike every other seal. Every hash in a seal is computed from the spec source only (compute_seal_hashesnever hashes the path), and eachspec_hashwas re-checked against the current spec file, so this is a path-only change.orbitofrontal_value.t27: the four switch arms are rewritten as anif / else-ifchain over the enum tag (recommended == .gf16, ...), same values per arm;PHI_INVis hoisted out of the arm. Tests unchanged. The parser is not touched.Only
.t27and tool-written seal data change.Refs #6507
Refs #6488
🤖 Generated with Claude Code