feat(t27b): array and struct parameters and locals the body assigns - #6584
Merged
Merged
Conversation
gHashTag
added
the
owner-approved-foreign
Contributor
Contributor
PR DashboardGenerated at: 2026-10-05 18:28:54 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6569
Refs #6063
What
var(var p = p_arg;) is copied into a slot of the callee at entry, and the body writes that copy. The reference decides this with t27c's owncollect_mutable_namestest, which names a StmtAssign target or the identifier base of an index or field target, walking if/while/for bodies. The caller's value never changes, as in the reference.constorlet, typed or not) is a writable slot of its own, as the reference'svaris. A copy is never an alias.cli/t27b/src/lower/refvars.rs.lower.rsgets small hooks:mod refvars;;begin_body;specs/tri/t27b/conformance/value_params.t27passest27c test-report(10 pass) and t27b (10 pass).Owner exception
Allowed by the owner 2026-10-05; debt to be replaced via #6198.
The local only-t27 hook (#6511) read an uncommitted line in
tools/policy/foreign-exceptions.txt. It namescli/t27b/src/lower.rs,cli/t27b/src/lower/refvars.rs,cli/t27b/tests/valueparams.rs,cli/t27b/tests/common/mod.rsandcli/t27b/tests/source.rs. That line is not in this PR. CI'sown-languagecheck honours theowner-approved-foreignlabel.Ledger bless (Q53)
docs/reports/t27b_expectations.jsonis re-blessed in this PR.corpus --blockers) are swapped in for the 3 specs it unlocks, and added for 3 specs newer than that run. With that run,tri t27b ratchetis green.rust_value_parameters.t27,uart_echo_top.t27andlamport.t27, each blocked (StmtAssign) to pass.value_params.t27(this PR);gft64.t27andfpga-build.t27(lab run 597216d);aggregate-experience.t27andgenerate_episodes.t27(feat(port): scripts/generate_episodes.sh to specs/port/scripts/generate_episodes.t27 (Closes #5644) #6581, feat(port): scripts/aggregate-experience.sh to specs/port/scripts/aggregate-experience.t27 (Closes #5862) #6582; local run).specs/numeric/gft{128,256,512,1024}.t27, blocked on wide integer types. They were added with--accept-new.Files
specs/tri/t27b/conformance/value_params.t27docs/reports/t27b_expectations.jsontri t27b ratchet --bless --accept-new)cli/t27b/src/lower.rs(hooks)cli/t27b/src/lower/refvars.rscli/t27b/tests/valueparams.rscli/t27b/tests/source.rs(one case dropped:const p = Pt{..}; p.x = 3;is accepted by the reference)docs/now/2026-10-06-t27b-value-params.mdTests
cargo test -p t27b: all green.tests/valueparams.rshas 3 tests:Corpus (
t27b corpus specs --blockers --reference <t27c> --reference-cache, jobs 8, after merging master 9c59c51)Three specs that the reference blocks now hit another t27b blocker first. None of them is counted:
sgd: nowExprIdentifier(undeclared);mlp: nowExprCall(undeclared fn);net: nowStmtLocal.🤖 Generated with Claude Code