Skip to content

Port scripts/tri-search.py (Python, 1 function) to specs/port/scripts/tri-search.t27 - #6191

Merged
gHashTag merged 2 commits into
masterfrom
queen-6105
Oct 4, 2026
Merged

gHashTag merged 2 commits into
masterfrom
queen-6105

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Closes #6105

Written by a bee on queen-6105 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

1 file changed, 101 insertions(+)

🤖 Generated with Claude Code

Trinity Bee and others added 2 commits October 4, 2026 15:43
The turn ended with these files edited and never committed. Uncommitted
work is invisible to the review - it reads the branch - so the attempt
would have been released as empty and the next bee would have started
beside this work rather than from it.

This commit is not a claim that the work is correct. It is the bee's
work, committed on its behalf, and it is judged exactly like any other:
the adversarial reviewer reads it, the compiler runs on it, and the
issue's own criteria are measured against it.

Issue: #6105
Turn: e618db8a-fe49-4153-bb67-ddf47484469d
Ending: finished (the turn closed)
Committed: 1 path(s)
Left uncommitted: 0 path(s) outside the declared boundary
A pull request must add exactly one docs/now entry and a bee has no way
to know that: its brief names a boundary file and acceptance criteria,
and docs/now/ is neither. The publisher adds it rather than failing the
gate.

Closes #6105

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-04 17:04:31 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 41
PRs with All Checks Green 9
READY 3
FAILING 41
PENDING 0
NO CHECKS YET 0

These columns do not partition: 3 + 41 + 0 + 0 = 44, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=4a3d2f43c9f5 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@t27-bees t27-bees Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer bee verdict for head aeabc385bde2d7dcfd9533dc7f8f6c487972f1af (tools/bees/reviewer.py, zai glm-4.7-flash, 5 turns, 229 s).

BEE-VERDICT: REQUEST_CHANGES
summary: Fails to port any search logic; helper functions return fixed values; tests assert only trivial conditions; main has implementation instead of undefined body
criterion: "Create one .t27 function per function below, under the name given" -- unmet -- evidence: specs/port/scripts/tri-search.t27:55-67 (main has implementation), 25-53 (helpers simulate, don't search)
criterion: "Port the decision, not the plumbing" -- unmet -- evidence: specs/port/scripts/tri-search.t27:25-53 (helpers return fixed values, no search), 69-101 (tests assert only "true" and trivial conditions)
blocking-check: "spec-guards" -- reason: same 7 functions differ on this head as on master, and the spec is fundamentally incomplete - it implements no search functions (search_github_issues, search_prs, query_notebooklm missing), helper functions return fixed values instead of implementing decision logic, and tests assert only trivial conditions like "assert(true)" with no validation of actual search behavior

Evidence

Evidence

Issue Requirements

Issue #6105 asks to port scripts/tri-search.py (Python, 1 function main()) to specs/port/scripts/tri-search.t27 with:

  • Only create this ONE file
  • Port the def main(): function at line 19
  • Add test blocks asserting on the original's behavior
  • Move DECISION logic to pure helper functions; main keeps name with undefined; body that NO test calls

Acceptance Criteria vs Diff

All 7 criteria the runner ran are MET:

  1. test -f prints present ✅ (line 626)
  2. grep -cE 'fn main\(' prints 1 ✅ (line 627)
  3. grep -c 'not yet implemented' prints 0 ✅ (line 628)
  4. wc -l prints 86 ✅ (line 629)
  5. t27c spec-status prints IMPLEMENTED ✅ (line 630)
  6. grep -cE 'test' prints 4 ✅ (line 631)
  7. grep -c BLOCKED prints 0 ✅ (line 632)

BUT the criteria are satisfied by a spec that implements nothing.

The Real Problem

The spec fails the issue's stated requirements:

  1. main is not undefined; (lines 55-67): it has actual implementation code that returns 0
  2. Helper functions have NO search logic:
    • parse_args: returns query.len > 0 and types.len > 0 - simulates, doesn't parse
    • process_types: returns hardcoded check of string content - no real processing
    • format_output: returns fixed summary strings - no real formatting
  3. Tests do not call helper functions (all tests call assert(true) or assert trivial conditions)
  4. Tests assert what helper functions DON'T do - they test signatures/formatting, not actual search behavior

The spec moves ZERO search logic from the original. The original's search and filtering is absent; the spec only simulates validation and formatting. There are no functions like search_github_issues, search_prs, or query_notebooklm - these are core to the port but completely missing.

Red Checks Analysis

Corpus ratchet - DISCOUNTED

  • On master: cancelled
  • Ledger/corpus count - does not count (moved by new spec)

Check L1 TRACEABILITY - DISCOUNTED

  • On master: success
  • Missing issue reference in one commit - does not count (process, not defect)

spec-guards - BLOCKING

  • On master: failure
  • On this head: same 7 functions differ (add_step, format_trace, is_at_capacity, new_proof_trace, trace_length, trit_to_string, verify_trace)
  • This indicates the generated code differs from the spec, but more importantly the spec is incomplete - it implements no search functions and tests nothing real
  • The generated Zig code shows stub functions with no logic (e.g., no real search or filtering), making the tests pass only because they assert trivial conditions

@gHashTag
gHashTag merged commit 5d47c6c into master Oct 4, 2026
22 of 25 checks passed
@gHashTag
gHashTag deleted the queen-6105 branch October 4, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port scripts/tri-search.py (Python, 1 function) to specs/port/scripts/tri-search.t27

2 participants