Make lowerability models retain real NN and ASP signature witnesses - #5922
Merged
dmitrii-f-t27 merged 1 commit intoOct 4, 2026
Merged
dmitrii-f-t27 merged 1 commit into
dmitrii-f-t27 merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NN lowerability models were empty after their real sources gained f64 functions, so their true theorems disagreed with the actual Rust classifier. Full Lean compilation also exposed an unused ASP dummy marker: its empty module could not prove the asserted false verdict. Retain real signature/type projections for phi_rope, sacred_attention and ASP, couple them to actual compiler generation, and import Completeness from the root library so the default Lake build checks it.
Closes #5910
Closes #5917
Refs #2895
Validation: full local bootstrap
cargo test --no-fail-fastpasses (2,792 passed, zero failed, two inherited ignored). Actual Lean4.31.0 compiles full Completeness and ten unchanged dependency modules with exact pinned Mathlib. Exact-head Linux CI also compiles Completeness successfully (22s). All three false-to-true mutants fail native_decide; an integer control passes; no sorryAx appears in the changed theorems. Old NN/ASP empty models fail the source guard. The required three checks, Corpus ratchet and GitGuardian pass on the exact source head. Compiler/classifier and all ledgers remain unchanged.These are negative structural signature projections with deliberately omitted bodies; they do not establish numerical correctness, solver correctness or complete inference. Whole-library CI remains red on unchanged H4Lagrangian and TernaryFPGABoot. Baseline and candidate locally reproduce the same H4 failures; the existing boot file is untouched. H4 proof repair is tracked in #5927/#3142, C test portability in #5907. No full-library/all-CI-green claim, exclusions, added admissions or ledger increase.