chore: move the assertionless ledger to the number that is true - #4271
Merged
Merged
Conversation
specs/fpga/testbench/vcd_conformance_compare_tb.t27 gained real assertions and its five placeholder tests are gone, so the corpus holds 4049 in 32 files against a ledger claiming 4054 in 33. The gate refuses that on purpose - a ceiling above the real number banks slack against the next regression - and it has failed on every push to master since 2026-09-17 12:53. Blessed with `python3 tools/check_assertionless_spec_tests.py --bless`; no .t27 file is touched. Closes #4270 Gates: python3 tools/check_assertionless_spec_tests.py -> "ok: no file gained an assertionless test, and none silently lost one." Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
September 18, 2026 14:15
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4270
Corpus Ratchetis red on master: a file improved (five placeholder tests replaced with real assertions) and the ledger still claimed the old ceiling. This moves the ledger, nothing else — no.t27file is touched.Before:
assertionless spec tests: 4049 in 32 file(s) (baseline 4054 in 33)→FAIL: 1 file(s) lost one.After:
ok: no file gained an assertionless test, and none silently lost one.🤖 Generated with Claude Code