fix(trit): ternary MAC adder_tree_27 overflow — wrong dot product on dense vectors

[gHashTag]

Model-critical correctness bug in the ternary MAC core, found by a new functional testbench.

Bug

adder_tree_27 (from gen-trit-stdlib, wrapped by trit27_dot_product → pipeline_stage2_compute) declared level-2 as wire signed [3:0] l2 [0:2]; (range [-8, +7]). But each l2[j] = l1[3j] + l1[3j+1] + l1[3j+2] with l1 ∈ [-3, +3] has range [-9, +9] — so a group of 9 same-sign trits (sum ±9, or even ±8) overflows.

Symptom: input = {27{+1}}, weight = {27{+1}} → expected dot product +27, actual −21 (each level-2 group of 9 wrapped +9 → −7; 3 × −7 = −21). Single-trit / sparse cases were correct, so the existing substring asserts never caught it.

Fix

Widen l2 to signed [4:0] (range [−16, +15]). Level-1 (signed [2:0] holds [−3,+3]) and level-3 (signed [5:0] holds [−27,+27]) were already correct.

Verification

New golden-vector functional testbench tests/bitnet_compute_mac.rs (iverilog + vvp) drives pipeline_stage2_compute with known trit chunks:

• allP×allP = +27, allP×allN = −27, allN×allN = +27, allZ = 0, single-trit = +1, multi-chunk +27 then −27 accumulates to 0.
  All pass after the fix; −21/+21 before it. Skips gracefully without iverilog. The unit test that had codified the buggy signed [3:0] width is updated.

trit_stdlib.rs is not under the FROZEN_HASH seal (only compiler.rs), so no reseal. Full suite green apart from the pre-existing, unrelated bitnet_top reds (#1726).

This is the functional instrument that makes the engine-top datapath fix (input≡weight aliasing at bitnet_top.rs:217) provable, per the observability-before-mutation discipline.

🤖 Generated with Claude Code

Closes #1732

[github-actions]

📓 NotebookLM Notebook linked to this PR

• Notebook ID: b83263109fb055dc
• URL: https://notebooklm.google.com/notebook/b83263109fb055dc

This notebook contains session context, decisions, and artifacts for this work.

[github-actions]

PR Dashboard

Generated at: 2026-08-05 18:00:49 UTC

• fix(trit): ternary MAC adder_tree_27 overflow — wrong dot product on dense vectors #1733 fix(trit): ternary MAC adder_tree_27 overflow — wrong dot product on dense vectors | Created: 2026-08-05 | Updated: 2026-08-05 | 10 failing / 20 total
• feat(igla): Wave Loop 880 — module-scope [579][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1720 feat(igla): Wave Loop 880 — module-scope [579][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 879 — module-scope [577][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1711 feat(igla): Wave Loop 879 — module-scope [577][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 3 total
• feat(igla): Wave Loop 878 — module-scope [575][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1707 feat(igla): Wave Loop 878 — module-scope [575][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 3 total
• feat(igla): Wave Loop 877 — module-scope [573][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1705 feat(igla): Wave Loop 877 — module-scope [573][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 3 total
• feat(igla): Wave Loop 876 — module-scope [571][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1704 feat(igla): Wave Loop 876 — module-scope [571][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 3 total
• feat(igla): Wave Loop 875 — module-scope [569][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1700 feat(igla): Wave Loop 875 — module-scope [569][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 3 total
• feat(igla): Wave Loop 874 — module-scope [567][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1698 feat(igla): Wave Loop 874 — module-scope [567][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 873 — module-scope [565][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1695 feat(igla): Wave Loop 873 — module-scope [565][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 872 — module-scope [563][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1693 feat(igla): Wave Loop 872 — module-scope [563][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 871 — module-scope [561][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1692 feat(igla): Wave Loop 871 — module-scope [561][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 870 — module-scope [559][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1689 feat(igla): Wave Loop 870 — module-scope [559][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 869 — module-scope [557][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1687 feat(igla): Wave Loop 869 — module-scope [557][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 868 — module-scope [555][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1685 feat(igla): Wave Loop 868 — module-scope [555][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 867 — module-scope [553][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1683 feat(igla): Wave Loop 867 — module-scope [553][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 866 — module-scope [551][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1681 feat(igla): Wave Loop 866 — module-scope [551][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 865 — module-scope [549][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1679 feat(igla): Wave Loop 865 — module-scope [549][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 864 — module-scope [547][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1677 feat(igla): Wave Loop 864 — module-scope [547][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 863 — module-scope [545][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1671 feat(igla): Wave Loop 863 — module-scope [545][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 862 — module-scope [543][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1669 feat(igla): Wave Loop 862 — module-scope [543][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 861 — module-scope [541][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1667 feat(igla): Wave Loop 861 — module-scope [541][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• Wave Loop 860 — module-scope [539][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1665 Wave Loop 860 — module-scope [539][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• Wave Loop 859 — module-scope [537][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1663 Wave Loop 859 — module-scope [537][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• Wave Loop 858 — module-scope [535][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1661 Wave Loop 858 — module-scope [535][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 857 — module-scope [533][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1657 feat(igla): Wave Loop 857 — module-scope [533][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 3 total
• feat(igla): Wave Loop 856 — module-scope [531][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1655 feat(igla): Wave Loop 856 — module-scope [531][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 855 — module-scope [529][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1651 feat(igla): Wave Loop 855 — module-scope [529][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 854 — module-scope [527][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1649 feat(igla): Wave Loop 854 — module-scope [527][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 853 — [525][2]^6 Pt module-scope AoS variable from call with indexed signed writes #1647 feat(igla): Wave Loop 853 — [525][2]^6 Pt module-scope AoS variable from call with indexed signed writes | Created: 2026-08-05 | Updated: 2026-08-05 | 1 failing / 4 total
• feat(igla): Wave Loop 852 — [523][2]^6 Pt module-scope AoS variable from call with indexed signed writes #1645 feat(igla): Wave Loop 852 — [523][2]^6 Pt module-scope AoS variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 4 total
• feat(igla): Wave Loop 851 — [521][2]^6 Pt module-scope AoS variable from call with indexed signed writes #1643 feat(igla): Wave Loop 851 — [521][2]^6 Pt module-scope AoS variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 4 total
• feat(igla): Wave Loop 850 — module-scope [519][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1641 feat(igla): Wave Loop 850 — module-scope [519][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 4 total
• Wave Loop 849 — module-scope [517][2]^6 Pt packed AoS variable from call with indexed signed writes #1639 Wave Loop 849 — module-scope [517][2]^6 Pt packed AoS variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 4 total
• Wave Loop 848 — module-scope [515][2]^6 Pt packed AoS variable from call with indexed signed writes #1637 Wave Loop 848 — module-scope [515][2]^6 Pt packed AoS variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 4 total
• Wave Loop 847 — [513][2]^6 Pt non-power-of-two AoS call-write witness (1-MiBit boundary) #1635 Wave Loop 847 — [513][2]^6 Pt non-power-of-two AoS call-write witness (1-MiBit boundary) | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• Wave Loop 846 — [511][2]^6 Pt non-power-of-two AoS call-write witness #1633 Wave Loop 846 — [511][2]^6 Pt non-power-of-two AoS call-write witness | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 845 — module-scope [509][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1631 feat(igla): Wave Loop 845 — module-scope [509][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 844 — module-scope [507][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1629 feat(igla): Wave Loop 844 — module-scope [507][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 843 — module-scope [505][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1627 feat(igla): Wave Loop 843 — module-scope [505][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 842 — module-scope [503][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1625 feat(igla): Wave Loop 842 — module-scope [503][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 841 — module-scope [501][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1623 feat(igla): Wave Loop 841 — module-scope [501][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 840 — module-scope [499][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1621 feat(igla): Wave Loop 840 — module-scope [499][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 839 — module-scope [497][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1619 feat(igla): Wave Loop 839 — module-scope [497][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 838 — module-scope [495][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1617 feat(igla): Wave Loop 838 — module-scope [495][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-04 | Updated: 2026-08-04 | 1 failing / 3 total
• feat(igla): Wave Loop 837 — module-scope [493][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1615 feat(igla): Wave Loop 837 — module-scope [493][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-02 | Updated: 2026-08-02 | 1 failing / 3 total
• feat(igla): Wave Loop 836 — module-scope [491][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1613 feat(igla): Wave Loop 836 — module-scope [491][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-02 | Updated: 2026-08-02 | 1 failing / 3 total
• feat(igla): Wave Loop 835 — module-scope [489][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1611 feat(igla): Wave Loop 835 — module-scope [489][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-02 | Updated: 2026-08-02 | 1 failing / 3 total
• feat(igla): Wave Loop 834 — module-scope [487][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1609 feat(igla): Wave Loop 834 — module-scope [487][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-01 | Updated: 2026-08-01 | 1 failing / 4 total
• feat(igla): Wave Loop 833 — module-scope [485][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1607 feat(igla): Wave Loop 833 — module-scope [485][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-01 | Updated: 2026-08-01 | 1 failing / 3 total
• feat(igla): Wave Loop 832 — module-scope [483][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1605 feat(igla): Wave Loop 832 — module-scope [483][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-01 | Updated: 2026-08-01 | 1 failing / 3 total

Summary

Status	Count
Total Open PRs	50
PRs with Failing Checks	1
PRs with All Checks Green	49
READY	0
FAILING	1
PENDING	0

Seal Status

• ⚠️ STALE -- sha256(compiler.rs)=864a709e6e17 != manifest seal=87e5cbd3ad94.
  The committed NMSE numbers were certified against an older compiler.rs.
  Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).