Repository navigation
test(bitnet): elaborate the assembled engine bundle under iverilog - #1731
Merged
Merged
Conversation
The BitNet HLS modules were checked only by substring asserts on emitted Verilog; nothing elaborated the assembled engine, so a missing module or port mismatch stayed invisible -- the same blind spot that let the stale bitnet_top asserts (#1726) sit red. New integration test generates the bundle + trit stdlib and runs iverilog -g2012 -t null -s bitnet_engine_top over all RTL, asserting clean elaboration; skips when iverilog is absent. Test-only; no compiler change, no reseal. Closes #1730 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BitNet HLS modules were validated only by substring assertions on the emitted Verilog. Nothing elaborated the assembled engine, so structural breakage (a missing module, a port/width mismatch, a syntax error) stayed invisible until hardware — the same blind spot that let the stale
bitnet_topasserts (#1726) sit red unnoticed.Closes #1730.
What this adds
tests/bitnet_elaborate.rs— an integration test that:gen-bitnet-bundle --output-dir).gen-trit-stdlib) alongside it — the bundle instantiatestrit27_dot_productbut does not include the stdlib that defines it (a real gap; self-containing the bundle is a follow-up on test: no test elaborates the assembled BitNet engine bundle (structural blind spot) #1730 since it shifts the index-based bundle tests).iverilog -g2012 -t null -s bitnet_engine_topover all RTL modules (excluding the SVA property file, which isn't iverilog-parseable) and asserts clean elaboration.iverilogis not on PATH.Why it's meaningful (not a no-op)
During bring-up this exact instrument caught
Unknown module type: trit27_dot_product— proving it detects real structural defects. It establishes the observability needed before any engine-top datapath change (e.g. the input≡weight aliasing atbitnet_top.rs:217, where both compute operands currently read the same weight BRAM).Test-only; no compiler change, no reseal. Full local run green.
Pre-existing unrelated
bitnet_top::{top_busy..., top_mem_outputs_tied_off}reds (#1726) are untouched here.🤖 Generated with Claude Code