What is wrong
gate-topology fails on every open pull request:
Unclassified workflows carrying a pull_request branch filter: 0
UNCLASSIFIED ROSE 24 -> 25
A workflow was added and named in neither list, so this check
does not read it.
The twenty-fifth is queen-feed-untested.yml, merged an hour ago in #4307. The
gate exists precisely so that a workflow cannot arrive unread, and it caught it.
What to write
It belongs in NOT_MERGE_CRITICAL for the same reason its sibling
queen-feed-empty-bodies.yml does: it opens issues on a schedule and its own
failure gates no merge. Classifying it returns the count to the ceiling rather
than raising the ceiling.
Acceptance criteria
-
python3 scripts/ci/check_pr_branch_filters.py prints a line beginning CLEAN: (today: it prints UNCLASSIFIED ROSE 24 -> 25)
-
grep -c 'queen-feed-untested' scripts/ci/check_pr_branch_filters.py prints 1 (today: 0)
-
grep -c 'MAX_UNCLASSIFIED = 24' scripts/ci/check_pr_branch_filters.py prints 1 - the ceiling must not be raised to bless this
Boundary
scripts/ci/check_pr_branch_filters.py
What is wrong
gate-topologyfails on every open pull request:The twenty-fifth is
queen-feed-untested.yml, merged an hour ago in #4307. Thegate exists precisely so that a workflow cannot arrive unread, and it caught it.
What to write
It belongs in
NOT_MERGE_CRITICALfor the same reason its siblingqueen-feed-empty-bodies.ymldoes: it opens issues on a schedule and its ownfailure gates no merge. Classifying it returns the count to the ceiling rather
than raising the ceiling.
Acceptance criteria
python3 scripts/ci/check_pr_branch_filters.pyprints a line beginningCLEAN:(today: it printsUNCLASSIFIED ROSE 24 -> 25)grep -c 'queen-feed-untested' scripts/ci/check_pr_branch_filters.pyprints1(today: 0)grep -c 'MAX_UNCLASSIFIED = 24' scripts/ci/check_pr_branch_filters.pyprints1- the ceiling must not be raised to bless thisBoundary
scripts/ci/check_pr_branch_filters.py