Skip to content

smoke_gate: the verify-lean phase is declared but never executed #2268

Description

@gHashTag

Narrow slice of #2263, sized to what can be fixed without a judgement call.

smoke_gate takes run_verify_lean and declares verify_lean_ok, but nothing assigns it — the block that ran the phase was dropped by a batch merge. So (!run_verify_lean || verify_lean_ok) is false whenever a caller asks for the phase, and the regression test asks for it.

The block exists verbatim in 494e659. Restoring it is unambiguous: no later edit touches that region.

(The sibling flags dry_run_sweep_ok and validate_lean_standalone_ok have the same defect but their region carries a deliberate later edit — those stay in #2263 for a decision.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions