Conversation
Add .gitleaks.toml with the shared gHashTag rules (canonical copy in gHashTag/t27 PR #6433) plus narrow allowlists for the verified non-secrets on dev: the third-party WebBench eval CSVs, the public Sentry minidump DSN key, the extension manifest public key, an npm package name in bun.lock and one test fixture string. Wire gitleaks into the existing lefthook pre-commit and pre-push, add the CI twin (secret-scan workflow), and document the rule in README. Issues are disabled on this repository, so there is no issue to close. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gitleaks 8.30 applies a global [[allowlists]] block that has paths and condition = "AND" to the whole file: a planted wifi_password line in a matching path was not reported. Drop paths from those blocks and keep exact line regexes only. Verified: full scan exits 0, a probe line in each formerly allowlisted file now exits 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue to close: issues are disabled on gHashTag/BrowserOS.
What changed
.gitleaks.toml: the shared gHashTag rules (canonical copy in gHashTag/t27 PR #6433, includinghardcoded-password-literal), plus narrow allowlists for the verified non-secrets ondev.lefthook.yml: the existing config is extended, not replaced. Asecret-gatecommand is added topre-commit(staged changes) andpre-push(commits not yet on a remote)..github/workflows/secret-scan.yml: the CI twin. It scans the PR or push range, so--no-verifycannot bypass it.README.md: a "Secrets never enter the repository" section.Triage of the 413 findings on
dev. All are false positives:packages/browseros-agent/apps/eval/data/webbench/browserusefinal.csv, a third-party WebBench eval dataset. The task prompts include benchmark test-site logins (path allowlist for that data dir's CSVs).kSentryMinidumpUrlin two chromium patches. This is a Sentry client DSN key, which is public by design and ships in the binary (line allowlist).apps/agent/wxt.config.ts, the Chrome extension manifest public key that pins the extension ID (path AND line allowlist).bun.lock, the npm package name@inquirer/password(line allowlist).packages/shared/tests/smoke.test.ts, a test fixture string (line allowlist).Verified
gitleaks dir . --config .gitleaks.tomlexits 0.wifi_passwordliteral makesgitleaks git --staged --config .gitleaks.toml .exit 1.lefthook install --forceexits 0.core.hooksPathis set locally, so plaininstallrefuses. This commit went through the pre-commitsecret-gate, and the push went through the pre-pushsecret-gate.Credentials to rotate
None. No hardcoded credentials of ours were found.
馃 Generated with Claude Code