feat(queen): a lane can be signed with a GitHub login - #511
Merged
Merged
Conversation
This project lives on GitHub - the issues, the branches, the pull requests a bee opens are all there - so the person who lends a lane is nearly always someone with a GitHub account. `TRIOS_KEY_OWNERS="1=@alex"` now travels to the board as `github: "alex"`, and the page can show a face and link the profile instead of a bare string. The login is validated against GitHub's own rule (alphanumerics and single hyphens, never at either end, at most 39 characters) because the handle becomes a link to a person's profile and the URL of their avatar: a display name that merely contains an `@` must not be able to point the board at a stranger's account. `@alex/../torvalds`, `@alex.png`, `mail@example.com` and a 40-character handle are all refused by name in the test. Nothing is fetched from GitHub: the handle travels as text and the page builds the avatar URL, so a leaderboard read never waits on GitHub or a rate limit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRIOS_KEY_OWNERS="1=@alex"now travels to the board asgithub: "alex", so the leaderboard can show a face and link the profile instead of a bare string. This project lives on GitHub — the issues, the branches, the pull requests a bee opens are all there — so the person who lends a lane is nearly always someone with an account there.The login is validated against GitHub's own rule (alphanumerics and single hyphens, never at either end, at most 39 characters), because the handle becomes a link to a person's profile and the URL of their avatar: a display name that merely contains an
@must not be able to point the board at a stranger's account.@alex/../torvalds,@alex.png,mail@example.comand a 40-character handle are each refused by name in the test.Nothing is fetched from GitHub here: the handle travels as text and the page builds the avatar URL, so a leaderboard read never waits on GitHub or a rate limit.
Checks
bun test apps/server/tests/api/queen-leaderboard.test.ts— 9 pass, 37 expect() calls.Board side: gHashTag/trinity#1132.
🤖 Generated with Claude Code