Repository navigation
CI: share the Conan cache with pull requests, retry downloads longer - #7
Merged
Merged
Conversation
A cache saved by a pull request is only visible to that pull request, so each new pull request rebuilt all the dependencies (~1h on Windows). Caches saved on master are visible to all of them. - Build on master when build-related files change. - Never cancel the builds on master and on tags, only on pull requests. - Do not save the cache of a cancelled build, which could be incomplete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A temporary outage of github.com (HTTP 504) when downloading the pybind11 sources made a build fail: retry 5 times, every 20s, instead of 2 times, every 5s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI improvements.
Share the Conan cache with pull requests. GitHub only shows a cache saved by a pull request to that same pull request. Our caches were all saved by pull requests, so each new pull request rebuilt every dependency: ~1h on Windows instead of ~20 min. Caches saved on
masterare visible to every pull request, so:masterwhen build-related files change, with the same paths as for pull requests. Path filters don't apply to tags, so releases still run on everyv*tag. Each build onmasteralso gives the wheels of the currentmasteras artifacts.masterand on tags are never cancelled. Only a run on a pull request is cancelled by a new push to it.Retry longer when a download fails. A temporary github.com outage (HTTP 504) while downloading the pybind11 sources made a build fail. Conan now retries these downloads 5 times, every 20 s, instead of 2 times, every 5 s (
tools.files.download:retry/retry_wait). Downloads from the Conan server (core.download:*) can only be configured in the user'sglobal.conf, which the script shouldn't modify.Expected cost: changing
ci/conan_deps.shchanges the cache key, so this pull request rebuilds all the dependencies once (~1h on Windows). After the merge, the run onmastersaves caches that later pull requests will use.🤖 Generated with Claude Code